Ticket #9930 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Coverity - Issues in Vates files

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 3.3
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

There are Coverity issues in the Vates module that need fixing.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Michael Reuter

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Michael Reuter

Refs #9930. Fixing issues in TimeStepToTimeStep.

Changeset: c351c1fda7d5f9764b43bc6d8e317372f1fbaabb

comment:4 Changed 6 years ago by Michael Reuter

Refs #9930. Fixing issue in TimeToTimeStep.

Changeset: cad958c9816259bbd0214dde9b0d6c5b8028fd6e

comment:5 Changed 6 years ago by Michael Reuter

Refs #9930. Fixing issue in DimensionWidget.

Changeset: 3e01958f212c89d4bd58bd687b3fa3215db3f9c9

comment:6 Changed 6 years ago by Michael Reuter

Refs #9930. Fixing issue in MdViewerWidget.

Changeset: ff3589a3d08c334ce5e3a5a88c4e6a78814d446a

comment:7 Changed 6 years ago by Michael Reuter

Refs #9930. Fixing issue in SynchronisingGeometryPresenter.

Changeset: 62cb7b2c3d16347f4c157caeaa1176fee578479b

comment:8 Changed 6 years ago by Michael Reuter

Refs #9930. Forgot that VS2012 hates C++11.

Changeset: d85055c3725e1284238446d84f0dc80c10e348c4

comment:9 Changed 6 years ago by Michael Reuter

  • Status changed from inprogress to verify
  • Resolution set to fixed

The branch can be found ​here.

To test: You can look at coverity for the errors generated and make sure the fixes do what they should. Check to make sure that the tests are passing.

comment:10 Changed 6 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:11 Changed 6 years ago by Nick Draper

  • Status changed from verifying to verify
  • Tester Nick Draper deleted

comment:12 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:13 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9930_coverity_vates'

Full changeset: ​636d883fa90c36c1120f37fe315667352c56d202

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10772

Note: See TracTickets for help on using tickets.