Context Navigation

← Previous Ticket
Next Ticket →

Ticket #9958 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

LiveData ISIS features

Reported by:	Owen Arnold	Owned by:	Roman Tolchenov
Priority:	critical	Milestone:	Release 3.3
Component:	Framework	Keywords:
Cc:	timothy.charlton@…	Blocked By:
Blocking:		Tester:	Anders Markvardsen

Description (last modified by Roman Tolchenov) (diff)

LiveData requirement raised by Tim Charlton:

Need to be able to pre-filter the live data by spectrum number or range of spectrum numbers
Need to be able to pre-filter the live data by period

I'm initially assigning this to Nick, but it should probably be done by Roman.

Some ISIS instruments (LET, MERLIN) can have the monitors in different time regimes to the data spectra. LiveData should be able to determine the monitors' time regime and load them.

Change History

comment:1 Changed 6 years ago by Nick Draper

Status changed from new to assigned

comment:2 Changed 6 years ago by Nick Draper

Owner changed from Nick Draper to Roman Tolchenov

comment:3 Changed 6 years ago by Roman Tolchenov

Description modified (diff)

comment:4 Changed 6 years ago by Roman Tolchenov

Status changed from assigned to inprogress

Re #9958. Monitor can have different time regime.

Changeset: b605bbc5d30894ece44d350edc512d4b0cd293b7

comment:5 Changed 6 years ago by Roman Tolchenov

Re #9958. StartLiveData passes properties to listener.

Changeset: 6a65050c05e6e1a831183d0f7ac8fd8a71cb48f0

comment:6 Changed 6 years ago by Roman Tolchenov

Re #9958. Set spectra list via listener's property.

Changeset: 8154ae3ce97f867cefd4a248fc7ef78ad96a5faf

comment:7 Changed 6 years ago by Roman Tolchenov

Merge branch 'master' into feature/9958_livedata_isis_features

Conflicts:

Code/Mantid/Framework/LiveData/src/ISISHistoDataListener.cpp

Re #9958.

Changeset: 8a89105d0f75e99e5ace06140e96039d5bd4abe9

comment:8 Changed 6 years ago by Roman Tolchenov

Re #9958. Fixed to the unit test. Temporarily disabled a test.

Changeset: c4017ae560c8c63282cad7f77e601ef4eab0f78e

comment:9 Changed 6 years ago by Roman Tolchenov

Re #9958. Fix compiler warnings.

Changeset: c97d61cece38a458a5c4f8be1c5ba14d38bc9a8c

comment:10 Changed 6 years ago by Roman Tolchenov

Re #9958. Fix unit test.

Changeset: c7359d34ffcf6bf0e35d3b7408ebf57349f228f7

comment:11 Changed 6 years ago by Roman Tolchenov

Re #9958. Selecting periods to load.

Changeset: eea40bfc984868c787f91ed674b30907f5193211

comment:12 Changed 6 years ago by Roman Tolchenov

Re #9958. Fix Linux and Mac tests.

Changeset: 0f273d9f650f5717281084121e3fbb89589ad282

comment:13 Changed 6 years ago by Roman Tolchenov

To test

Run StartLiveData both with real instruments and the fake DAE.
Try various values for Periods and SpectraList properties.
Check that SpectraList and Periods are defined for ISIS histogram instruments only.
To run the fake DAE: switch to TEST_LIVE facility; start FakeISISHistoDAE algorithm, set some run parameters; start LiveData with ISIS_Histogram instrument.

NB. FakeISISHistoDAE creates 3 additional spectra to the number set by NSpectra property.

Last edited 6 years ago by Roman Tolchenov (previous) (diff)

comment:14 Changed 6 years ago by Roman Tolchenov

Re #9958. Fix ubuntu compiler warning.

Changeset: 7d7c7dadf5d6339f4ce2b901219ac77d47d6fdcf

comment:15 Changed 6 years ago by Roman Tolchenov

Status changed from inprogress to verify
Resolution set to fixed

comment:16 Changed 6 years ago by Martyn Gigg

Status changed from verify to verifying
Tester set to Martyn Gigg

comment:17 Changed 6 years ago by Martyn Gigg

Status changed from verifying to reopened
Resolution fixed deleted

For the most part this seems to work well. The property manager is a sensible addition to sync the properties between StartLiveData & the listener.

A couple of things I noted:

I started FakeISISHistoDAE with the default 100 spectra and then with StartLiveData I asked for SpectraList=101 expecting to get an error but it continued and produced a spectrum with the value {{{Y=101}} in it.
I ran FakeISISHistoDAE with 3 periods and then StartLiveData with Periods=2,3. This gives the correct output workspaces but in the group they are named ws_1 & ws_2, which I think might cause confusion about what has actually been loaded.

Could I also suggest that we rename the Periods property to PeriodList? It's more consistent with SpectraList and less ambiguous as I first thought it meant the number of periods to load.