Ticket #9978 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Improvements to SetSampleMaterial

Reported by: Nick Draper Owned by: Peter Peterson
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

Noted by Spencer:

We have a couple of simple but significant problems in SetSampleMaterial.

  1. SampleNumberDensity and SampleNumberDensityResult input and output in different units (one is per formula and one is per atom). It doesn't matter which we change but they should be the same.
  2. For all Xsections the documentation needs to state the unit is Barns per ?. Currently it appears to be barns per atom, but not stated.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Peter Peterson

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Pete Peterson

Re #9978. Updating documentation to clarify what parameters mean.

Changeset: 3f3ad601617255974a752fe0a0e91c54fea6ad8a

comment:4 Changed 6 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #31.

comment:5 Changed 6 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:6 Changed 6 years ago by Vickie Lynch

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/9978_set_sample_material'

Full changeset: ​ff1c465d83e87a55c25823a3bcc4f6a45bc50def

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10820

Note: See TracTickets for help on using tickets.