Ticket #10004 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

ReflectometryReductionOneAuto ProcessingInstructions

Reported by: Owen Arnold Owned by: Harry Jeffery
Priority: critical Milestone: Release 3.3
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

ReflectometryReductionOneAuto 'thinks' that both a PointDetectorStart and a PointDetectorStop must be present in order to run and that they cannot be equivalent. Make the logic here similar to that for CropWorkspace.

Currently ReflectometryReductionOneAuto will not run on SURF data without proviging the ProcessingCommand inputs.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Owen Arnold

  • Owner changed from Owen Arnold to Harry Jeffery

comment:3 Changed 6 years ago by Owen Arnold

This reduction should be possible without having to specify point_detector='2'

point_detector = '2'

q_110504, lam_110504, theta_110504 = ReflectometryReductionOneAuto('110504', ThetaIn=0.35,  FirstTransmissionRun='110503', ProcessingInstructions=point_detector)

comment:4 Changed 6 years ago by Owen Arnold

Following our discussion about having behaviour similar to CropWorkspace, I find that the PerformIndexOperations (used by ReflectometryReductionOne to do the work) does in fact behave the same as CropWorkspace, so we don't need to do anything other than handle the case that PointDetectorStart = PointDetectorStop.

Crop two spectra

ws = CreateWorkspace(DataX=[1,2,3,1,2,3,1,2,3], DataY=range(0,9), NSpec=3)
cropped = CropWorkspace(ws, StartWorkspaceIndex=0, EndWorkspaceIndex=1)
processed = PerformIndexOperations(ws, ProcessingInstructions='0,1')

Crop to single spectra

ws = CreateWorkspace(DataX=[1,2,3,1,2,3,1,2,3], DataY=range(0,9), NSpec=3)
cropped = CropWorkspace(ws, StartWorkspaceIndex=0, EndWorkspaceIndex=0)
processed = PerformIndexOperations(ws, ProcessingInstructions='0')

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

Construct ProcessingInstructions correctly.

The ProcessingInstructions field was being constructed incorrectly. Ranges were being specified using a comma, when the correct notation is to use a colon. This patch amends this error, and also takes care of the case where the start and end of the range are the same.

Refs #10004

Changeset: a641bcc5ee6c0d2dbac49f7e65cc73ea9e05df2e

comment:6 Changed 6 years ago by Harry Jeffery

Fix regressed test.

Refs #10004.

Changeset: 9f048b5a047f5df6783789f26d1d83c6231a9a8d

comment:7 Changed 6 years ago by Harry Jeffery

Fix regressed test. (For real this time)

Refs #10004

Changeset: 4ea8c85ed5b1a0d481ec9eb0f15a7018a920792a

comment:8 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:10 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:11 Changed 6 years ago by Owen Arnold

Will verify after the nightly system tests run.

comment:12 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10004_reflectometryreductiononeauto'

Full changeset: 41499fd74eb0c37f3a0b332d82ff3a334a82e047

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10846

Note: See TracTickets for help on using tickets.