Ticket #10008 (closed: fixed)
Changes to fitting that help integrate FABADA into Mantid
Reported by: | Roman Tolchenov | Owned by: | Roman Tolchenov |
---|---|---|---|
Priority: | major | Milestone: | Release 3.3 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Owen Arnold |
Description
FABADA will be implemented in Mantid as a minimizer but it requires additional features to be provided by the fitting framework:
- The minimizer must know the current iteration number and the maximum number of iterations.
- It must be able to declare additional output workspace properties.
Change History
comment:2 Changed 6 years ago by Roman Tolchenov
Re #10008. Copy output workspaces from minimizer to Fit.
Changeset: da5950fce9fd840bb98a7ef5be19e08ea4ee6598
comment:3 Changed 6 years ago by Roman Tolchenov
Re #10008. Added a unit test.
Changeset: 543530ee19faa6fe083535bab84926a6b6e4ac4c
comment:4 Changed 6 years ago by Roman Tolchenov
Re #10008. Fix doxygen and windows compiler warnings.
Changeset: 35ae2b8c629f3d145f66fffe833bf1a6b34d88da
comment:6 Changed 6 years ago by Roman Tolchenov
- Status changed from assigned to inprogress
Re #10008. Fixed a system test.
Changeset: c67cc7c9b660fbe8bd86dd27255de939411dfce2
comment:7 Changed 6 years ago by Roman Tolchenov
Re #10008. FitPropertyBrowser's support for minimizer int properties.
Changeset: fca89dafff4ff8583b38c4d72476e70a048bae61
comment:8 Changed 6 years ago by Roman Tolchenov
Re #10008. Fixing a build.
Changeset: 85669733182c05178a357f8d47e61856d29a34a0
comment:9 Changed 6 years ago by Roman Tolchenov
- Status changed from inprogress to verify
- Resolution set to fixed
To tester:
- Open the fit browser, prepare it for a fit of some data and some function (doesn't matter which).
- Select Fake from the Minimizer list. New properties should appear at the bottom of the browser: SomeOutput, SomeInt, SomeDouble and SomeString.
- Give those properties some values.
- Set MaxIterations to something other than default value.
- Run Fit.
- There should be an additional workspace created witch name is the value of SomeOutput.
- The workspace has 1 spectrum and MaxIterations bins. The Y values contain linearly increasing numbers from 0 to 1. This tests that MaxIterations and current iteration numbers get passed to the minimizer.
- First error value == SomeInt, second error value == SomeDouble. This tests that ints and doubles get passed to the minimizer.
- Plot the spectrum. The x axis label should be equal to the value of SomeString.
Fake minimizer will be removed in #10031. There are changes to systemtests in this ticket.
comment:10 Changed 6 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:11 Changed 6 years ago by Owen Arnold
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10008_fitting_changes_for_FABADA'
Full changeset: 629b47cc445249d6db4350cb67433de11e430e87
comment:12 Changed 6 years ago by Owen Arnold
Merge remote-tracking branch 'origin/feature/10008_fitting_changes_for_FABADA'
Full changeset: 9333bcdcbd58ef9929f7e4f56542d28adbbb991d
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10850
Re #10008. Pass iteration number to minimizers.
Changeset: dfea39646a07db0ce3aad423615ab8d8c1120a5d