Ticket #10028 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Solve issue about changing value direction in GenerateEventsFilter

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: critical Milestone: Release 3.2.1
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #10069 Tester: Owen Arnold

Description

It is found that in some cases the number of events of the filtered workspace by log value containing both changing direction is not equal to the sum of the events of the workspaces filtered with only increasing and only decreasing log value changing directions.

Further investigation shows that the problem is caused by the algorithm to determine the changing direction on the boundary of increasing and decreasing log value.

Attachments

verify10028.py (1.9 KB) - added by Wenduo Zhou 6 years ago.

Change History

comment:1 Changed 6 years ago by Wenduo Zhou

Refs #10028. Solved one issue in filtering by single value.

Issue: it was not considered about how to deal with the situation that if two adjacent log entries' values are identical.

The new algorithm is to extend the previous direction.

Changeset: 3bba77c98fe193b38f5d6951942b89f305965c16

comment:2 Changed 6 years ago by Wenduo Zhou

Refactored codes to identify log value. Refs #10028.

Changeset: 5428692476077e65c02b87a20b6f0dbb431214b0

comment:3 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Wenduo Zhou

  • Status changed from assigned to inprogress

Rewrote the method. Refs #10028.

Changeset: a77b830479d11ad052a7871fb80da7c56fba6c69

comment:5 Changed 6 years ago by Wenduo Zhou

Solved some issues about log boundary. Refs #10028.

Changeset: 6b8f6fe62301dc6107a03e29d444eda1ba16a275

comment:6 Changed 6 years ago by Wenduo Zhou

Corrected unit tests. Refs #10028.

Changeset: 24f1e9581fb0537bca18c6496622dff3b6d1f36d

comment:7 Changed 6 years ago by Wenduo Zhou

Improved doc. Refs #10028.

Changeset: 40badadf3bf5dd31687d83cc2ec6a110838238bb

comment:8 Changed 6 years ago by Wenduo Zhou

Refs #10028. Corrected an error for integer log.

The correction to unit test was made as well. The documentation is modified for integer sample log.

Changeset: c688a244bc9a4af9defe91f0c018c60fe9200b37

comment:9 Changed 6 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

For tester

Download the attached script verify10028.py. You can find that the number of events in both direction is equal to the sum of number of events in increasing and decreasing direction.

You can set correctiontype to 'None' or 'Elastic'.

All the unit tests and system tests related shall pass.

Changed 6 years ago by Wenduo Zhou

comment:10 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:11 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10028_generate_filter_direction'

Full changeset: 0dd0c355153fd5c5ad71219206f8f658ec97c692

comment:12 Changed 6 years ago by Owen Arnold

  • Blocking 10069 added

comment:13 Changed 6 years ago by Peter Peterson

  • Keywords PatchCandidate added

comment:14 Changed 6 years ago by Martyn Gigg

  • Keywords PatchCandidate removed
  • Milestone changed from Release 3.3 to Release 3.2.1

comment:15 Changed 6 years ago by Wenduo Zhou

Cherry-pick fixes from bugfix/10028_generate_filter_direction

into next

Changes:

Refs #10028. Solved one issue in filtering by single value.

Issue: it was not considered about how to deal with the situation that if two adjacent log entries' values are identical.

The new algorithm is to extend the previous direction. (cherry picked from commit 3bba77c98fe193b38f5d6951942b89f305965c16)

Refactored codes to identify log value. Refs #10028. (cherry picked from commit 5428692476077e65c02b87a20b6f0dbb431214b0)

Rewrote the method. Refs #10028. (cherry picked from commit a77b830479d11ad052a7871fb80da7c56fba6c69)

Solved some issues about log boundary. Refs #10028. (cherry picked from commit 6b8f6fe62301dc6107a03e29d444eda1ba16a275)

Corrected unit tests. Refs #10028. (cherry picked from commit 24f1e9581fb0537bca18c6496622dff3b6d1f36d)

Improved doc. Refs #10028. (cherry picked from commit 40badadf3bf5dd31687d83cc2ec6a110838238bb)

Refs #10028. Corrected an error for integer log.

The correction to unit test was made as well. The documentation is modified for integer sample log. (cherry picked from commit c688a244bc9a4af9defe91f0c018c60fe9200b37)

Changeset: 736f649e35f555639e1765acd309d6e91b4a1e92

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10870

Note: See TracTickets for help on using tickets.