Ticket #10039 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Replace code in Goniometer::getEulerAngles with calls to Quat::getEulerAngles

Reported by: Martyn Gigg Owned by: Harry Jeffery
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: anders.markvardsen@… Blocked By:
Blocking: Tester: Andrei Savici

Description

The implementation of Goniometer::getEulerAngles is practically identical to Quat::getEulerAngles. The code in Goniometer should be refactored to use the Quat implementation.

Change History

comment:1 Changed 6 years ago by Harry Jeffery

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by Harry Jeffery

Refs #10039. Make Goniometer::getEulerAngles use Quat impl.

Changeset: 93d74f260bd3d28c398ff1181b899b56c3415821

comment:4 Changed 6 years ago by Harry Jeffery

Goniometer::getEulerAngles is already well used outside of Goniometer itself, and exposed to Python scripts.

It's possible to remove Goniometer::getEulerAngles completely, and refactor all calls to it to use Quat(gon.getR()).getEulerAngles("XYZ") but it seems like messier code, not cleaner.

In addition, removing the method would break any python scripts that call it (including the usage example in the documentation for SetGoniometer v1).

Instead, Goniometer::getEulerAngles now simply wraps Quat::getEulerAngles.

Testing

Check no tests fail.

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 6 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:7 Changed 6 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10039_refactor_goniometer_geteulerangles'

Full changeset: 16ce3830008fbce85bec2c5203cfb90cf055efb1

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10881

Note: See TracTickets for help on using tickets.