Ticket #10050 (assigned)
Merge in Tube Calibration Changes from Richard
Reported by: | Peter Parker | Owned by: | Anton Piccardo-Selg |
---|---|---|---|
Priority: | major | Milestone: | Backlog |
Component: | SANS | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: |
Description
At some point we need to merge in Richard's changes to the Tube Calibration code. This will get to be a bigger and bigger issue the longer we leave it.
Change History
comment:4 Changed 5 years ago by Peter Parker
- Owner changed from Peter Parker to Anton Piccardo-Selg
Anton:
There is a slide about this (with a "before" and "after" screenshot) in the intro slides we went through during the handover.
Basically, we need to get the latest version of the script(s) used by Richard to calibrate the SANS2D detector tubes and get that in Git. These scripts also require some modifications to Karl's underlying tube calibration code.
It may take some work to integrate Richard's changes without breaking existing tests (if there are any) and existing functionality. I would advise caution here, since changes to this code obviously could have far-reaching consequences outside of ISIS SANS.