Ticket #10057 (closed: fixed)
Indirect algorithm: IndirectTrans
Reported by: | Dan Nixon | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | major | Milestone: | Release 3.3 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | spencer.howells@… | Blocked By: | #10092 |
Blocking: | #9969, #10274 | Tester: | Anders Markvardsen |
Description
Convert this script into a Python algorithm with suitable unit testing.
Change History
comment:3 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Moved script to IndirectTrans algorithm
Refs #10057
Changeset: 4e1082ff4adbdb56bb8fe08b118dad347c02a2ab
comment:4 Changed 6 years ago by Dan Nixon
- Cc spencer.howells@… added
- Summary changed from Move IndirectTrans python script to algorithm to Move IndirectTrans Python script to algorithm
comment:5 Changed 6 years ago by Dan Nixon
Fixed some issues in IndirectTrans algorithm, add test
Added unit test and required test data
Refs #10057
Changeset: 696900be889833ed3b91ed74b5ac868be12716c7
comment:6 Changed 6 years ago by Dan Nixon
Gave IndirectTrans a more meaningful name, added docs
Refs #10057
Changeset: a33257f781d4a449991404423e844764bc6b0a27
comment:8 Changed 6 years ago by Dan Nixon
Merge branch 'bugfix/10057_indirecttrans_python_algorithm' into develop
Conflicts:
Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt
Refs #10057
Changeset: 408190d86cb865d5d9c9c4724af8f24a8a1e3418
comment:9 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
To test, attempt to use the Transmission tab in Indirect Data Reduction, resulting transmission workspace should be identical to one produced by an earlier version of Mantid (e.g. 3.2).
Verify that the algorithm is in appropriate categories and the help file is suitable.
comment:10 Changed 6 years ago by Martyn Gigg
- Status changed from verify to reopened
- Resolution fixed deleted
It looks like the category name has a spelling error that has caused a systemtest to fail:
comment:11 Changed 6 years ago by Dan Nixon
- Status changed from reopened to inprogress
Corrected typo which broke system tests
Refs #10057
Changeset: 66749a9f8c89749f2f9b1a1dd2ffaec99f1e6c74
comment:12 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:13 Changed 6 years ago by Dan Nixon
- Status changed from verify to reopened
- Resolution fixed deleted
Looking at this again I doubt plotting from inside an algorithm is a good idea, will move this back to the UI.
comment:14 Changed 6 years ago by Dan Nixon
- Status changed from reopened to inprogress
Added file properties for algorithm input files
Refs #10057
Changeset: 05d83dcb62fe5f4f17e03a8a37907278e7fcec34
comment:15 Changed 6 years ago by Dan Nixon
I'm not sure if there is a standard way to create a plot form a custom interface, a lot of the time I see Python being used for this.
I have left the plotting in the algorithm for now.
comment:16 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:17 Changed 6 years ago by Dan Nixon
Catch correct exception type in unit test
Refs #10057
Changeset: f757c606c0c3b7ffaf43f04eda1282efdf67c75e
comment:18 Changed 6 years ago by Samuel Jackson
- Status changed from verify to verifying
- Tester set to Samuel Jackson
comment:19 Changed 6 years ago by Dan Nixon
Updated IndirectTransmissionMonitor to use workspaces
Refs #10057
Changeset: e3fb9eeca7212f48156ce8ef68aaf9a87b4e6282
comment:21 Changed 6 years ago by Dan Nixon
- Status changed from verifying to reopened
- Resolution fixed deleted
comment:23 Changed 6 years ago by Dan Nixon
- Summary changed from Move IndirectTrans Python script to algorithm to Indirect algorithm: IndirectTrans
comment:24 Changed 6 years ago by Dan Nixon
Improved documentation and unit test
Refs #10057
Changeset: 9778c8e835226c4f929d564576b8d5bf5ab592dd
comment:25 Changed 6 years ago by Dan Nixon
Merge branch 'bugfix/10057_indirecttrans_python_algorithm' into develop
Conflicts:
Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt
Refs #10057
Changeset: 408190d86cb865d5d9c9c4724af8f24a8a1e3418
comment:26 Changed 6 years ago by Dan Nixon
TODO: Spencer has noted that the can workspace name should be added to the sample logs of the output workspace.
comment:27 Changed 6 years ago by Dan Nixon
Merge branch 'master' into bugfix/10057_indirecttrans_python_algorithm
Conflicts:
Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt Code/Mantid/scripts/Inelastic/IndirectEnergyConversion.py
Refs #10057
Changeset: 27ff22bf0f62cc1a395e9706451aa468250fdede
comment:28 Changed 6 years ago by Dan Nixon
Refactoring, add can_workspace to trans. workspace logs
Refs #10057
Changeset: fced160c17a89d9dabd239a085fedf6be6b9d342
comment:29 Changed 6 years ago by Dan Nixon
comment:30 Changed 6 years ago by Dan Nixon
Merge branch 'bugfix/10057_indirecttrans_python_algorithm' into develop
Conflicts:
Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/IndirectDataReduction.ui
Refs #10057
Changeset: 910d742427996ba5dcbcd648c61ad4d8358bc601
comment:31 Changed 6 years ago by Dan Nixon
Try to get index of monitors and first detectior using IDF
Refs #10057
Changeset: 8da2aeafafb46297b7cfb95b7f1468d98f2a5df9
comment:32 Changed 6 years ago by Dan Nixon
comment:33 Changed 6 years ago by Dan Nixon
Added compatability with instruments with only one monitor
e.g. TOSCA
Refs #10057
Changeset: 6076b9a2933bcb4f06c6e9e2629c7f7f5d15f322
comment:34 Changed 6 years ago by Dan Nixon
Fix typo in transmission monitor usage example
Refs #10057
Changeset: b366ab8e7b0564b20b71afb813a9ba42801759e4
comment:35 Changed 6 years ago by Dan Nixon
Added output naming testing to unit test
Refs #10057
Changeset: a35419372faaa5d9166908c1bf113c8dbb9eb087
comment:36 Changed 6 years ago by Dan Nixon
Set literals don't exist in Python 2.6
Refs #10057
Changeset: 73929f7e81a8345f3a7a22069d184cae4aa02111
comment:38 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
To test:
- Ensure system test ISISIndirectInelasticTransmissionMonitor is passing
- Open Indirect > Data Reduction > Transmission and run with sample IRS26176 and can IRS26173
- Ensure the can workspace appears in th sample logs
- Play with the output options and ensure they work as intended
Note that there are changes to systemtests with this ticket.
comment:40 Changed 6 years ago by Anders Markvardsen
- Status changed from verify to verifying
- Tester changed from Samuel Jackson to Anders Markvardsen
comment:41 Changed 6 years ago by Dan Nixon
- Status changed from verifying to closed
Merge branch 'master' into bugfix/10057_indirecttrans_python_algorithm
Conflicts:
Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt Code/Mantid/scripts/Inelastic/IndirectEnergyConversion.py
Refs #10057
Full changeset: 27ff22bf0f62cc1a395e9706451aa468250fdede
comment:42 Changed 6 years ago by Anders Markvardsen
Merge remote-tracking branch 'origin/bugfix/10057_indirecttrans_python_algorithm'
Full changeset: 6e1a45e71131a98a71181108d8340da16777e8ee
comment:43 Changed 6 years ago by Anders Markvardsen
Merge remote-tracking branch 'origin/bugfix/10057_indirecttrans_python_algorithm'
Full changeset: fa5c8960722d49a64af9940fb762d072e84f5a59
comment:44 Changed 6 years ago by Dan Nixon
Merge branch 'master' into bugfix/10057_indirecttrans_python_algorithm
Conflicts:
Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt Code/Mantid/scripts/Inelastic/IndirectEnergyConversion.py
Refs #10057
Full changeset: 27ff22bf0f62cc1a395e9706451aa468250fdede
comment:45 Changed 6 years ago by Anders Markvardsen
Merge remote-tracking branch 'origin/bugfix/10057_indirecttrans_python_algorithm'
Full changeset: 6e1a45e71131a98a71181108d8340da16777e8ee
comment:46 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10899