Ticket #10062 (verifying: fixed)
Improve handling of locations tag in IDF parsing
| Reported by: | Martyn Gigg | Owned by: | Harry Jeffery |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.5 |
| Component: | Framework | Keywords: | Maintenance |
| Cc: | Blocked By: | ||
| Blocking: | #10063 | Tester: | Martyn Gigg |
Description (last modified by Martyn Gigg) (diff)
In #9860 I had a look at profiling the instrument loading code as it's never been done and I was curious as to what it spends a lot of its time doing.
I came across the InstrumentDefinitionParser::convertLocationsElement function and found that it seems as if the implementation first creates the XML that would have been in the file without the locations tag and then parses this.
Can we improve this by simply creating the new elements directly in C++ rather than converting to and from XML again?
Change History
comment:4 Changed 6 years ago by Anders Markvardsen
- Keywords Maintenance added
- Milestone changed from Release 3.3 to Release 3.4
comment:5 Changed 5 years ago by Anders Markvardsen
- Milestone changed from Release 3.4 to Release 3.5
comment:6 Changed 5 years ago by Anders Markvardsen
- Owner changed from Anders Markvardsen to Harry Jeffery
comment:8 Changed 5 years ago by Harry Jeffery
Refs #10062 Don't convert to string form
Changeset: 1e0454ad4b70b5283c3f35a7394d89d88e5d35f3
comment:9 Changed 5 years ago by Harry Jeffery
Refs #10062 Traverse the DOM more efficiently
Changeset: 4f16e566e15d980b3ab47fc2edd8bca7dba5021a
comment:10 Changed 5 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #827.
comment:11 Changed 5 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10904
