Ticket #10065 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Indirect algorithm: CreateCalibrationWorkspace

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: samuel.jackson@…, spencer.howells@… Blocked By: #10092
Blocking: #9969 Tester: Alex Buts

Description (last modified by Dan Nixon) (diff)

This step is not used outside of the Indirect Calibration tab, hence it can just be moved to it's own algorithm.

Change History

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned
  • Cc samuel.jackson@… added

comment:2 Changed 6 years ago by Dan Nixon

  • Description modified (diff)

comment:3 Changed 6 years ago by Dan Nixon

  • Blocked By 10092 added

comment:4 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Moved CreateCalibrationWOrkspace to it's own algorithm

Refs #10065

Changeset: 83838a3e4ea7088573e822aa8578e19f1d0ebb08

comment:5 Changed 6 years ago by Dan Nixon

Better use of property types

Refs #10065

Changeset: 3926b83f37429f2bea0cdbf01fcdbe6be6d78d77

comment:6 Changed 6 years ago by Dan Nixon

Algorithm refactoring, implemented into GUI

Refs #10065

Changeset: 19a5b2677bd4254840c78a5ed96688f86832b61e

comment:7 Changed 6 years ago by Dan Nixon

More UI fixes, re-add old resolution

Refs #10065

Changeset: 59d82b5c39e6bc5003bbd0d5f9dc7394405e6f4e

comment:8 Changed 6 years ago by Dan Nixon

Update CreateCalibrationWOrkspace documentation

Refs #10065

Changeset: 089b949a2ce73b6fcc8caf932e3525842a142aa9

comment:9 Changed 6 years ago by Dan Nixon

  • Component changed from Framework to Indirect Inelastic

comment:10 Changed 6 years ago by Dan Nixon

systemtests 739dec5bfea1ae3fbfbcf65a3de62c44f19d4637

Modified calibration test for new algorithm

comment:11 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  • Ensure system tests IRISCalibration and OSIRISCalibration are passing
  • Open Indirect > Data Reduction > Calibration
  • Perform calibration using default options (IRS26173 is suitable data)
  • Change the peak and background ranges and ensure the algorithm still runs
  • Play with the output options and ensure they work as intended (save gives a *_calib.nxs in default save directory

Note that there are changes to systemtests with this ticket.

Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:12 Changed 6 years ago by Dan Nixon

Correct property type that may have caused doctest issues

Refs #10065

Changeset: 45525b3b20b0818ec2abae9e1731ccb1e0016963

comment:13 Changed 6 years ago by Dan Nixon

Use an example file that is in UsageData

Refs #10065

Changeset: b4d1a212f67140a44638cd4957389e475f25ad3b

comment:14 Changed 6 years ago by Dan Nixon

Improved logging on CreateCalWS

Refs #10065

Changeset: 3d92b7170b719f70805aad442911e422115ccdab

comment:15 Changed 6 years ago by Dan Nixon

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:16 Changed 6 years ago by Dan Nixon

  • Status changed from reopened to inprogress

Temp. removal of failing doc test

Refs #10065

Changeset: 74dbac6e96a4b6ab09811bd43c972bc12f807031

comment:17 Changed 6 years ago by Dan Nixon

Attempt to fix numpy issue

Refs #10065

Changeset: 0409ba1034c239cd3a3be61c06c5a1ff1ad234af

comment:18 Changed 6 years ago by Dan Nixon

Correct obvious typo

Refs #10065

Changeset: b81502e9cfb84f6b409cdaa7c1b16cef273070b1

comment:19 Changed 6 years ago by Dan Nixon

Re-add CreateCalibrationWorkspace tests

Refs #10065

Changeset: 880c4f2e9e9b98f49e2ef674c2a4bfd853430efe

comment:20 Changed 6 years ago by Dan Nixon

Added unit test, small documentation change

Refs #10065

Changeset: 54da07efdd5721eff42923d215ad9c3506dc7623

comment:21 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:22 Changed 6 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:23 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge branch 'master' into bugfix/10065_indirect_createcalibrationworkspace_algorithm

Conflicts:

Code/Mantid/scripts/Inelastic/inelastic_indirect_reduction_steps.py

Full changeset: ​e3e7654dffbb9f3219896ca50922480dd25e4098

comment:24 Changed 6 years ago by Alex Buts

Merge remote-tracking branch 'origin/bugfix/10065_indirect_createcalibrationworkspace_algorithm'

Full changeset: ​1ed36d9de0d561a40e5e1c9fada171be2e1f1e6d

comment:25 Changed 6 years ago by Alex Buts

Merge remote-tracking branch 'origin/bugfix/10065_indirect_createcalibrationworkspace_algorithm'

Full changeset: ​244dea2c2e93e0e4d8a613e077fbc5c617ad8f6a

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10907

Note: See TracTickets for help on using tickets.