Ticket #10104 (closed: fixed)
ConjoinWorkspaces does not fix spectrum number
Reported by: | Wenduo Zhou | Owned by: | Wenduo Zhou |
---|---|---|---|
Priority: | blocker | Milestone: | Release 3.2.1 |
Component: | Framework | Keywords: | |
Cc: | petersonpf@… | Blocked By: | |
Blocking: | Tester: | Peter Peterson |
Description
ConjoinWorkspaces does not fix spectrum number if CheckOverLapping is set to false. It leaves the spectrum and workspace index maps broken in the output workpspaces.
If CheckOverLapping is set to true, then algorithm should be stopped with an exception thrown.
Change History
comment:2 Changed 6 years ago by Wenduo Zhou
For tester
Run the command as below
x = ConjoinFiles(RunNumbers="19771-19779", Directory="/SNS/PG3/IPTS-10108/shared/autoreduce/")
You will find that "Color Fill Plot" of the workspace "x" will not show 9 spectra properly but 1. "Plot Spectra" will show there is only 1 spectra but 9 workspace indexes.
Merge the change from this ticket and rebuild Mantid, re-run the command and you will see everything correct.
comment:4 Changed 6 years ago by Wenduo Zhou
- Status changed from assigned to verify
- Resolution set to fixed
comment:5 Changed 6 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester changed from petersonpf@ornl.gov to Peter Peterson
comment:6 Changed 6 years ago by Pete Peterson
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/10104_conjoinworkspaces_fixspectrum'
Full changeset: 59ed9c517fb40d713a2029dcde7c8ebeb355a572
comment:7 Changed 6 years ago by Peter Peterson
- Keywords PatchCandidate removed
- Milestone changed from Release 3.3 to Release 3.2.1
comment:8 Changed 6 years ago by Martyn Gigg
Cherry-pick fixes from bugfix/10104_conjoinworkspaces_fixspectrum
into next
Changes:
Refs #10104. Fixed the issue.
and added some sentences in docs. (cherry picked from commit acd0cc879d1095aa9b049ea06d313db0eb222b12)
Conflicts:
Code/Mantid/docs/source/algorithms/ConjoinWorkspaces-v1.rst
Changeset: 67ee877bc0f92cd704b29561768ec29483ca89cb
Refs #10104. Fixed the issue.
and added some sentences in docs.
Changeset: acd0cc879d1095aa9b049ea06d313db0eb222b12