Ticket #10116 (closed: fixed)
Refl_gui should not delete input workspaces once finished.
Reported by: | Owen Arnold | Owned by: | Harry Jeffery |
---|---|---|---|
Priority: | major | Milestone: | Release 3.3 |
Component: | Reflectometry | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | #10196 | Tester: | Owen Arnold |
Description
The original workspace corresponding to the runnumber gets deleted at the end of processing. Look for call to DeleteWorkspace in refl_gui.py. This should not happen. Keep all loaded TOF workspaces in a group.
- Look to see if a group called TOF exists. If it does, add this run workspace to that group.
- If not create the group and add the workspace.
- Overwrite anything already in the group with the same name.
Change History
comment:2 Changed 6 years ago by Harry Jeffery
- Status changed from assigned to inprogress
Prevent TOF workspaces from being cleaned up.
Refs #10116.
Changeset: ddd8b79ccab11d6174f89a797799779afebfe9fd
comment:4 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
comment:5 Changed 6 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:6 Changed 6 years ago by Owen Arnold
- Status changed from verifying to reopened
- Resolution fixed deleted
call WorkspaceGroup::contains prior to WorkspaceGroup::add to check if the workspace already exists. That way we can avoid the warnings appearing in the logs. This will worry the users.
comment:7 Changed 6 years ago by Harry Jeffery
- Status changed from reopened to inprogress
Check if workspace is in group before attempting to add it.
Refs #10116.
Changeset: d218d9cc9d200e146af3ac7ee90c044bd1d745dc
comment:8 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
comment:10 Changed 6 years ago by Owen Arnold
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10116_refl_gui_keep_tof_workspaces'
Full changeset: 0269bfb6c55a17dfe04b7ad8299c4a7c8bdf0c43
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10958