Ticket #10123 (closed: fixed)
Cannot save a table workspace that has a float column
Reported by: | Martyn Gigg | Owned by: | Roman Tolchenov |
---|---|---|---|
Priority: | major | Milestone: | Release 3.3 |
Component: | Framework | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Raquel Alvarez Banos |
Description
report = CreateEmptyTableWorkspace() report.addColumn(type='float', name="Percent") report.addRow([50.0]) report.addRow([75.0]) report.addRow([100.0]) filename = os.path.expanduser("~/floattable.nxs") SaveNexusProcessed(report, filename) loaded_report = LoadNexusProcessed(filename)
The script above shows that the loaded_report workspace comes back with nothing in it. It think this is due to the NexusFileIO::writeNexusTableWorkspace method not checking explicitly for float types.
Change History
comment:1 Changed 6 years ago by Nick Draper
- Status changed from new to assigned
- Owner set to Roman Tolchenov
comment:2 Changed 6 years ago by Roman Tolchenov
- Status changed from assigned to inprogress
Re #10123. Saving float and other numeric types.
Changeset: 841120dd92dbd68453f69bee91fe873ccd8af0d1
comment:3 Changed 6 years ago by Roman Tolchenov
Re #10123. Tests for saving numeric columns.
Changeset: ba9c6be838769a9d753441bf9b8d08949514c073
comment:4 Changed 6 years ago by Roman Tolchenov
Re #10123. Saving and loading numeric columns.
Changeset: 229e5f303c5e05f62bba5931d181b08931a04571
comment:5 Changed 6 years ago by Roman Tolchenov
Re #10123. Save and load V3D columns.
Changeset: 5a18c11b36c67c00911a5d1efe387c07521c7369
comment:6 Changed 6 years ago by Roman Tolchenov
Re #10123. Removed unused variable.
Changeset: 232151e3096de727de735142b4beba62f928c3ba
comment:7 Changed 6 years ago by Roman Tolchenov
Re #10123. Fix compiler warnings.
Changeset: e785066df403d64ba06d173505c302b0525ca4d7
comment:8 Changed 6 years ago by Roman Tolchenov
Re #10123. Use only fixed size ints in table columns.
Changeset: 7c89a921196e1f19f8d162addce5db39808b446b
comment:9 Changed 6 years ago by Roman Tolchenov
Re #10123. Temporarily revert changes that break tests.
Changeset: 59985c6d42156702c0dd8652098e0f5c83f0ed24
comment:10 Changed 6 years ago by Roman Tolchenov
Re #10123. Renamed column type names.
Changeset: a7d1ae57a7eb71e781c7336f4096e18b13a0db84
comment:11 Changed 6 years ago by Roman Tolchenov
Re #10123. Missed some size_t references in table columns.
Changeset: 824c2ca1fe9a913e1158bbd7d776a8e9eded2a0e
comment:12 Changed 6 years ago by Roman Tolchenov
Re #10123. Returned size_t to the column types.
size_t is converted to uint64_t on saving to nexus.
Changeset: f9d97ba59223f9954b7874b6bb4494b247e549c6
comment:13 Changed 6 years ago by Roman Tolchenov
Re #10123. Fixing CheckWorkspaceMatchTest
Changeset: 3e516e9c5ca0eac85ea1969608ecd4ed3604acbb
comment:14 Changed 6 years ago by Roman Tolchenov
Re #10123. Test for saving string columns.
Changeset: e75553453bb0b2c15038478c66082ab05a6c8d2b
comment:15 Changed 6 years ago by Roman Tolchenov
- Status changed from inprogress to verify
- Resolution set to fixed
To tester
Try also saving and loading other column types: uint, long64, size_t, bool, V3D.
comment:16 Changed 6 years ago by Raquel Alvarez Banos
- Status changed from verify to verifying
- Tester set to Raquel Alvarez Banos
comment:17 Changed 6 years ago by Raquel Alvarez Banos
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/10123_save_float_column'
Full changeset: 119349a149e71de3a6d21e6240f7e80cf872ec6f
comment:18 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10965