Ticket #10125 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add Save button to Mantid UI

Reported by: Samuel Jackson Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description

Suggested by Stewart Parker. We have buttons above the workspace list that load, delete, group and sort workspaces, but curiously not one for saving. I talked to Nick about this as it's a very visual change and he seemed to be in agreement.

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Owner changed from Samuel Jackson to Dan Nixon

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Added a save button to MantidDOck widget

Refs #10125

Changeset: c918721cee39b8b4f4293786bf60538c794df9a0

comment:4 Changed 6 years ago by Dan Nixon

Added error handling, moved save button

Moves save button to prevent accidental deletion of workspaces

Refs #10125

Changeset: 8df2510d14b38c2feec6d32ad55a4ee0c1e2c50e

comment:5 Changed 6 years ago by Dan Nixon

Merge branch 'bugfix/10125_add_save_button_to_workspace_list' into develop

Conflicts:

Code/Mantid/MantidPlot/src/Mantid/MantidDock.cpp

Refs #10125

Changeset: a6dd9efed58a360c390a9161a1e83223ca6dc17b

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  • Open several workspaces
  • With none selected click Save, nothing should happen
  • With one selected click Save, the SaveNexus algorithm window should be shown with the selected workspace selected in the algorithm window
  • With multiple selected click Save, this should ask for a folder and save each workspace in that folder with a filename identical to the workspace name

comment:7 Changed 6 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:8 Changed 6 years ago by Martyn Gigg

I had a quick look at this too and while the functionality does what it says I think we have an opportunity to clear up some consistency problems. At the moment the "Group" button is enabled/disabled depending on the context. However, none of the other buttons do this. I think it would be nice if both "Delete" and "Save" were only activated if there is an active selection.

Also, this is not techincally anything to do with this ticket but it's sufficiently small and targeted that I don't think it deserves its own ticket. When you have a WorkspaceGroup loaded and you click on it, the "Group" button turns to "UnGroup" with a capital "G" - this looks odd. Can we lowercase the "G"?

comment:9 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:10 Changed 6 years ago by Karl Palmen

I had a go at this and found I was not happy about the selection of directory/folder in the save dialog box 'choose' is an unsual word for such a dialog box and there seem to be no way to browse for the choice of save folder.

This occurred when I selected two workspaces in a group.

comment:11 Changed 6 years ago by Dan Nixon

  • Status changed from reopened to inprogress

Fixed small issues in MantidDock, improved save dialog

Refs #10125

Changeset: 0f5f04c85cb2b9616cb28db6708f02a51e5f1d61

comment:12 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

I have changed the window title to better reflect what the user is doing at this point and renamed the accept button to "Select".

Additions to testing:

  • Ensure Save and Delete buttons are only enabled when at least one workspace is selected
  • Ensure grouping and ungrouping still works as intended

comment:13 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester changed from Karl Palmen to Harry Jeffery

comment:14 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Merge conflict when merging into master.

comment:15 Changed 6 years ago by Dan Nixon

  • Status changed from reopened to inprogress

Merge branch 'master' into bugfix/10125_add_save_button_to_workspace_list

Conflicts:

Code/Mantid/MantidPlot/src/Mantid/MantidDock.cpp

Refs #10125

Changeset: 6a56c567b422e4a3b54f6e28e1a23977f9fc510d

comment:16 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:17 Changed 6 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester changed from Harry Jeffery to Karl Palmen

comment:18 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge branch 'master' into bugfix/10125_add_save_button_to_workspace_list

Conflicts:

Code/Mantid/MantidPlot/src/Mantid/MantidDock.cpp

Refs #10125

Full changeset: 6a56c567b422e4a3b54f6e28e1a23977f9fc510d

comment:19 Changed 6 years ago by Karl Palmen

Merge remote-tracking branch 'origin/bugfix/10125_add_save_button_to_workspace_list'

Full changeset: 5b0ae60309c3982505725d7749601a649d5fc3be

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10967

Note: See TracTickets for help on using tickets.