Ticket #10143 (closed: fixed)
Inst View: Extend parameter display to non detector objects
| Reported by: | Nick Draper | Owned by: | Roman Tolchenov |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.4 |
| Component: | GUI | Keywords: | |
| Cc: | Blocked By: | #10139 | |
| Blocking: | Tester: | Federico M Pouzols |
Description
Ticket #10139 allowed the parameters on detectors to be displayed on the detector tab.
This needs to be extended to work for non detector components e.g. choppers etc on MARI.
The function to create the parameter strings:
QString InstrumentWindowPickTab::getParameterInfo(Mantid::Geometry::IComponent_const_sptr comp)
should work nicely as long as you can feed it the component selected
Change History
comment:3 Changed 6 years ago by Roman Tolchenov
- Status changed from assigned to inprogress
Re #10143. Signal pickID instead of detector id when picking.
Changeset: bcef1e26df3cda54625a9f0f915086dee6ab4058
comment:4 Changed 6 years ago by Roman Tolchenov
Re #10143. Added info and plot controllers.
Changeset: 0cf7c8c6ac8ff902a0c57802a5cbd45e35b11bf7
comment:5 Changed 6 years ago by Roman Tolchenov
Re #10143. Connected plot controller.
Changeset: dad7491614bef06dfaa291d7a43aad918296ba1c
comment:6 Changed 6 years ago by Roman Tolchenov
Re #10143. Restored save to workspace. Display x axis units.
Changeset: b2c6220730a71e7ef5305bbb0e829774f4027890
comment:7 Changed 6 years ago by Roman Tolchenov
Re #10143. Information on non-detector components.
Changeset: e2465b26de5bd2442063f87b4c8230e2cb81126b
comment:8 Changed 6 years ago by Roman Tolchenov
Re #10143. Added component position info.
Changeset: e76adc4e7943138f751db41d6c3f1e3f297498b7
comment:9 Changed 6 years ago by Roman Tolchenov
Re #10143. Fix doxygen comments.
Changeset: 3afa7977578210572dfa9dce724fa658b22c8710
comment:10 Changed 6 years ago by Roman Tolchenov
Re #10143. Clean up unused code.
Changeset: ce91246408654e4eef4dcab66168403ceebc8cf8
comment:11 Changed 6 years ago by Roman Tolchenov
- Status changed from inprogress to verify
- Resolution set to fixed
To tester
Open a MARI (or any other instrument with non-detector components, eg choppers) workspace in Pick tab and check that it display information on both detectors and choppers.
The code has been significantly refactored in this ticket, so all other functionalities of Pick tab need to be tested as well.
comment:12 Changed 6 years ago by Federico M Pouzols
- Status changed from verify to verifying
- Tester set to Federico M Pouzols
comment:13 Changed 6 years ago by Federico M Pouzols
- Status changed from verifying to closed
It seems to be working well and the code looks very good to me, also well documented. I tested this with the MARI11001 example file and I can see information about choppers and other components. I played a bit with all the tools of the Pick tab and they seem to be working fine. Basic Python commands also seem to work well.
Incidentally, I found that some Python commands are not working well. I've opened another ticket (#10927) for that, although it may not be very high priority.
comment:14 Changed 6 years ago by Roman Tolchenov
Merge branch 'master' into feature/10143_display_non_detector_parameters
Full changeset: 403b2e87afcfadd6f12b866d8e4bfa36acd0c200
comment:15 Changed 6 years ago by Federico Montesino Pouzols
Merge remote-tracking branch 'origin/feature/10143_display_non_detector_parameters'
Full changeset: ad482db0b2981b2cbcd68906a3af6edc132ff7bc
comment:16 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10985
