Ticket #10149 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

LoadInstrument Tests

Reported by: Owen Arnold Owned by: Anders Markvardsen
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: nick.draper@… Blocked By:
Blocking: #9905 Tester: Owen Arnold

Description

Nick pointed out that the clean unit tests are incredibly slow:

​http://builds.mantidproject.org/job/develop_clean/lastCompletedBuild/label=rhel6-build/testReport/DataHandlingTest/LoadInstrumentTest/

The incremental ones are much faster. This indicates that the slow speed is because the instrument is too large, and creating the complex geometry (from which the vtp files are saved) is a huge bottleneck.

The target for IO related tests is < 5 seconds per suite.

Change History

comment:1 Changed 6 years ago by Anders Markvardsen

Improve loadinstrumenttest executation time. re #10149

by heavily cut down hrpd instrument used for unit testing

Changeset: e25df78de0d8a4ca8f53935a70b1bd68e22888fc

comment:2 Changed 6 years ago by Anders Markvardsen

Removed to unit test. re #10149

Removed testExecGEM and testExecHRP. These were added at early days of loadinstrument adding some of the first instruments to mantid.

More recently a systemtest has been added that test that all IDFs loads, hence the tests these performed are now covered elsewhere

Changeset: e9b1dfe8ab6740dbd60586ce1578eaa370d4fb61

comment:3 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Anders Markvardsen

  • Status changed from assigned to verify
  • Resolution set to fixed

According to ​http://builds.mantidproject.org/job/develop_clean/label=win7-build/307/testReport/DataHandlingTest/ running this unit test now takes less than 1 sec.

To tester: check that running loadinstrumenttest now that less than 5 secs

comment:5 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:6 Changed 6 years ago by Owen Arnold

Very impressive speedup. Down from 2 mins 19 seconds on rhel6 to 0.49 seconds. Well done! definitely the best improvement of any unit test during this maintenance window.

comment:7 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10991

Note: See TracTickets for help on using tickets.