Ticket #10168 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Remove EventWorkspaceTest parts that are linux only

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: critical Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

EventWorkspaceTest has parts that test memory usage and is only implemented for Linux. The test appears to fail under valgrind sometimes, see ​here, as the check for memory can be unreliable.

The test should be changed to just check how full the MRU lists are as this can be implemented cross platform in a reliable manner.

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Martyn Gigg

  • Status changed from assigned to inprogress

Check MRULists in EventWorkspaceTest

Instead of checking memory, which is unreliable cross platform, test the size of the MRUList at various points Refs #10168

Changeset: 1a5d14aba99d9504f02a6fcc6413b0e125c313f1

comment:3 Changed 6 years ago by Martyn Gigg

Branch: ​feature/10168_eventworkspacetest_all_platforms

Tester: The main problem that was fixed here was to get the tests more reliable under valgrind. The valgrind build of the ​core packages should now have been stable for a few runs. Check the code to see that you agree with the changes.

comment:4 Changed 6 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:6 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10168_eventworkspacetest_all_platforms'

Full changeset: ​36760b360cab607fac99ea9bfb95d8389a4fd911

comment:7 Changed 6 years ago by Owen Arnold

Happy with these changes. The job now looks more stable.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11010

Note: See TracTickets for help on using tickets.