Ticket #10179 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Split up of LoadBBY

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: major Milestone: Release 3.3
Component: SANS Keywords:
Cc: davidm@… Blocked By:
Blocking: Tester: Karl Palmen

Description (last modified by Anders Markvardsen) (diff)

Splitting up LoadBBY for code readability and in preparation for adding additional ANSTO loaders.

Note also here made some changes in accordance with http://www.mantidproject.org/C%2B%2B_Coding_Standards

Change History

comment:1 Changed 6 years ago by Anders Markvardsen

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Anders Markvardsen

The name of the branch to do pull request to is feature/10179_loadbby_style_update

comment:3 Changed 6 years ago by Anders Markvardsen

  • Status changed from assigned to inprogress

David Mannicke's split up of LoadBBY. re #10179

Changeset: 5dc710702c80e705fe16bb885b57edbcdd8a4868

comment:4 Changed 6 years ago by Anders Markvardsen

Note branch to commit to for this ticket is now feature/10179_bilby_split_up

comment:5 Changed 6 years ago by Anders Markvardsen

rename LoadANSTO + make it compile on Linux. re #10179

Changeset: 170e2853c4977bff6e32e0710295c21f199c851b

comment:6 Changed 6 years ago by Anders Markvardsen

get in to build on mac. re #10179

Changeset: 30ce78c2b190d6f1a946611a699da606e383d249

comment:7 Changed 6 years ago by Anders Markvardsen

Made a couple of comment visible to doxygen. re #10179

Changeset: 0484ae5d9effc000d11c9c3feb901259d15ffeb8

comment:8 Changed 6 years ago by Anders Markvardsen

  • Description modified (diff)
  • Summary changed from Update LoadBBY style to Split up of LoadBBY

comment:9 Changed 6 years ago by Anders Markvardsen

  • Status changed from inprogress to verify
  • Resolution set to fixed

To tester:

  1. check that code in LoadBBY has been split into loadANSTOHelper

comment:10 Changed 6 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:11 Changed 6 years ago by Karl Palmen

No unit test for LoadANSTOHelper. I'll create ticket for that.

comment:12 Changed 6 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10179_bilby_split_up'

Full changeset: ​387ba5e7117bb49128a948d9bf239dba2cc6954e

comment:13 Changed 6 years ago by Karl Palmen

Merge remote-tracking branch 'origin/feature/10179_bilby_split_up'

Full changeset: ​387ba5e7117bb49128a948d9bf239dba2cc6954e

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11021

Note: See TracTickets for help on using tickets.