Ticket #10182 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Make SNSPowderReduction to generate GSAS file same as V-Drive

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.3
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Vickie Lynch

Description

VULCAN instrument scientist wishes Mantid to generate same GSAS file from V-drive. The major reason of the difference is caused by the different ways to define binning between Mantid and IDL.

Some changes to related algorithm will be applied for investigation or better log information.

Attachments

verify10182.py (2.3 KB) - added by Wenduo Zhou 6 years ago.
vulcan_foc_all_2bank_11p.cal (404.5 KB) - added by Wenduo Zhou 6 years ago.
VULCAN_Characterization_2Banks_v2.txt (1.1 KB) - added by Wenduo Zhou 6 years ago.
characterization file
26299.gda (394.2 KB) - added by Wenduo Zhou 6 years ago.
GSAS file generated from V-drive
vdrive_log_bin.dat (39.2 KB) - added by Wenduo Zhou 6 years ago.

Change History

comment:1 Changed 6 years ago by Wenduo Zhou

Refs #10182. Made minor changes to algorithms related.

better log information more output to investigate the experiment data enabled user to specify the precision of offset value enabled to accept frequency's name and unit used for VULCAN added one property to specify tolerance to compress events

Changeset: 342aca3e08d3ec21be2627f2d380f85b8bb72bfb

comment:3 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

With any changes to output file formats we need to ensure that they are either optional (and not the default), or they are agreed with any other users of those algorithms.

comment:4 Changed 6 years ago by Wenduo Zhou

  • Status changed from assigned to inprogress

Fixed a bug. Refs #10182.

Changeset: b55585978b7761ccbd7b1ff5d3b91f56e4575310

comment:5 Changed 6 years ago by Wenduo Zhou

Refs #10182. Added algorithm to save GSAS file for VULCAN.

On branch feature/10182_reduce_vulcan Changes to be committed:

new file: ../Mantid/Framework/PythonInterface/plugins/algorithms/SaveVulcanGSS.py modified: ../Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt new file: ../Mantid/Framework/PythonInterface/test/python/plugins/algorithms/SaveVulcanGSSTest.py

Changeset: 7b46e8f4046485c3951777347a94fd61e5d46e3d

comment:6 Changed 6 years ago by Wenduo Zhou

Merge branch 'feature/10182_reduce_vulcan' into develop. Refs #10182.

Conflicts:

Code/Mantid/Framework/PythonInterface/test/python/plugins/algorithms/CMakeLists.txt

Changeset: e42edfabdb0b1b90287501c43dc8784e0a8f6b58

comment:7 Changed 6 years ago by Wenduo Zhou

Added methods to write VULCAN-required header. Refs #10182.

Changeset: 3478cb82c76b68ce60c3f733eeeab0fe3c958334

comment:8 Changed 6 years ago by Wenduo Zhou

Refs #10182. Added documentation.

On branch feature/10182_reduce_vulcan Changes to be committed:

modified: ../../Code/Mantid/Framework/DataHandling/src/SaveGSS.cpp

  • changed a log level.

modified: ../../Code/Mantid/Framework/PythonInterface/plugins/algorithms/SaveVulcanGSS.py

  • minor changes

new file: ../../Code/Mantid/docs/source/algorithms/SaveVulcanGSS-v1.rst

  • documentation

new file: UsageData/vdrive_log_bin.dat

  • test data

Changeset: 85f00fa956193813f3fa0f7ba6927281bd5256a4

comment:9 Changed 6 years ago by Wenduo Zhou

Tried to fix error in doc. Refs #10182.

Changeset: 935b4b8ce826d96c1916307706a5d61a809e0c2c

comment:10 Changed 6 years ago by Wenduo Zhou

Fixed doc test. Refs #10182.

Changeset: c740e70afa202ec9115bead13cda29c5c0410f90

comment:11 Changed 6 years ago by Wenduo Zhou

Cleaned the doc. Refs #10182.

Changeset: c96c9f448cd4bda98472820512968df6e0e3c285

comment:12 Changed 6 years ago by Wenduo Zhou

Removed some debugging output. Refs #10182.

Changeset: 20d76782c611aac34db8ef9a44ef33db6aac7fca

Changed 6 years ago by Wenduo Zhou

Changed 6 years ago by Wenduo Zhou

Changed 6 years ago by Wenduo Zhou

characterization file

Changed 6 years ago by Wenduo Zhou

GSAS file generated from V-drive

Changed 6 years ago by Wenduo Zhou

comment:13 Changed 6 years ago by Wenduo Zhou

For tester

Download all the attached files. Run verify10182.py. Check the difference between the GSAS files generated from Mantid and V-drive. The difference is trivial comparing to the total number of counts.

comment:14 Changed 6 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:15 Changed 6 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester set to Vickie Lynch

comment:16 Changed 6 years ago by Vickie Lynch

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/10182_reduce_vulcan'

Full changeset: c1e0f71e8c61d15cbdd1d6e1cf509199e33a6524

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11024

Note: See TracTickets for help on using tickets.