Ticket #10198 (closed: fixed)
TwoTheta's value is not inserted into refl_gui's table
| Reported by: | Harry Jeffery | Owned by: | Harry Jeffery |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.3 |
| Component: | Reflectometry | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #10201, #10202 | Tester: | Owen Arnold |
Description
When CalculateResolution is run by refl_gui.py, the user may choose not to provide a value for TwoTheta, and have the algorithm extract a value for it from the workspace's log. However, the extracted value is never retrofitted into the main table in refl_gui.py
To fix this:
- CalculateResolution should provide TwoTheta as an output.
- refl_gui should update the value of TwoTheta in its table with the value returned by CalculateResolution.
Change History
comment:2 Changed 6 years ago by Harry Jeffery
- Status changed from assigned to inprogress
- Summary changed from TwoTheta's value is not inserted into the table to TwoTheta's value is not inserted into refl_gui's table
comment:3 Changed 6 years ago by Harry Jeffery
Make CalculateResolution output TwoTheta.
Refs #10198.
Changeset: 469dae71b6773fed4a30656f49c4785d728ed0c5
comment:4 Changed 6 years ago by Harry Jeffery
Update the value of TwoTheta in refl_gui's table.
Refs #10198.
Changeset: 943ca37f71e95ea4302c6d1ff00ee5c5198c7fb7
comment:6 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
comment:7 Changed 6 years ago by Martyn Gigg
- Status changed from verify to reopened
- Resolution fixed deleted
The usage tests for CalculateResolution have broken: http://builds.mantidproject.org/job/develop_doctest/152/console
comment:8 Changed 6 years ago by Harry Jeffery
- Status changed from reopened to inprogress
Fix CalculatResolution regression and update docs.
Refs #10198.
Changeset: 50e193e9078f605c0cac085238dea340a4222e9d
comment:9 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
Usage example test is now passing.
comment:10 Changed 6 years ago by Owen Arnold
- Status changed from verify to verifying
- Tester set to Owen Arnold
comment:11 Changed 6 years ago by Owen Arnold
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10198_place_value_of_twotheta_into_refl_table'
Full changeset: bb2eb66f4bdb8dde5f4aefca3aaed185f7d0f63b
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11040
