Ticket #10216 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Remove defects in SaveCalFile and LoadVulcanCalFile reported from coverity

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: reuterma@… Blocked By:
Blocking: Tester: Karl Palmen

Description

Defect(s) Reported-by: Coverity Scan Showing 5 of 5 defect(s)

CID 1237305: Uninitialized scalar variable (UNINIT) /home/builder/jenkins-linode/workspace/coverity_build_and_submit/Code/Mantid/Framework/DataHandling/src/LoadVulcanCalFile.cpp: 574 in Mantid::DataHandling::LoadVulcanCalFile::convertOffsets()()

CID 1237304: Uninitialized scalar variable (UNINIT) /home/builder/jenkins-linode/workspace/coverity_build_and_submit/Code/Mantid/Framework/DataHandling/src/LoadVulcanCalFile.cpp: 574 in Mantid::DataHandling::LoadVulcanCalFile::convertOffsets()()

CID 1237303: Uninitialized scalar variable (UNINIT) /home/builder/jenkins-linode/workspace/coverity_build_and_submit/Code/Mantid/Framework/DataHandling/src/LoadVulcanCalFile.cpp: 574 in Mantid::DataHandling::LoadVulcanCalFile::convertOffsets()()

CID 1237307: Uninitialized scalar field (UNINIT_CTOR) /home/builder/jenkins-linode/workspace/coverity_build_and_submit/Code/Mantid/Framework/DataHandling/src/SaveCalFile.cpp: 28 in Mantid::DataHandling::SaveCalFile::SaveCalFile()()

CID 1237306: Uninitialized scalar field (UNINIT_CTOR) /home/builder/jenkins-linode/workspace/coverity_build_and_submit/Code/Mantid/Framework/DataHandling/src/LoadVulcanCalFile.cpp: 45 in Mantid::DataHandling::LoadVulcanCalFile::LoadVulcanCalFile()()

Change History

comment:1 Changed 6 years ago by Wenduo Zhou

Refs #10216. Solved all 5 reported issue.

On branch feature/10216_correct_coverity Changes to be committed:

modified: ../Mantid/Framework/DataHandling/src/LoadVulcanCalFile.cpp modified: ../Mantid/Framework/DataHandling/src/SaveCalFile.cpp

Changeset: b54e3db429b5d44cb90aa1f26db53f7a816217ea

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Wenduo Zhou

  • Status changed from assigned to verify
  • Resolution set to fixed

For tester

Check the change of the codes, which have minor change. Check whether any unit test is broken by these change.

comment:4 Changed 6 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:5 Changed 6 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10216_correct_coverity'

Full changeset: ​c80e164df9710492892cfb1828e45243b29d9f56

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11058

Note: See TracTickets for help on using tickets.