Ticket #10217 (closed: wontfix)

Opened 6 years ago

Last modified 5 years ago

Qmin, Qmax calculations in refl_gui

Reported by: Owen Arnold Owned by: Harry Jeffery
Priority: major Milestone: Release 3.3
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

This line:

https://github.com/mantidproject/mantid/blob/master/Code/Mantid/scripts/Interface/ui/reflectometer/refl_gui.py#L982

Is performing the same unit conversion defined for Momentum Transfer here : http://www.mantidproject.org/Unit_Factory

We are now very close to stripping all calculations out of the refl_gui. It would be good to create a temp SingleValue workspace for this lambda value, and then run ConvertUnits rather than keeping the fragile calculation above. Ask Owen Arnold if this doesn't make sense. Be careful that you can reproduce exactly the same result. You will need to do this sort of thing in the new gui anyway.

Need to ask about the following one. Create a separate ticket for this one when done with the above.

https://github.com/mantidproject/mantid/blob/master/Code/Mantid/scripts/Interface/ui/reflectometer/refl_gui.py#L757

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Harry Jeffery

  • Blocked By 9880 added

comment:3 Changed 6 years ago by Harry Jeffery

  • Blocked By 9880 removed

comment:4 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to verify
  • Resolution set to wontfix

Using ConvertUnits would be verbose and far heavier than needed, with no benefit and poorer readability. The old UI is slowly being deprecated, so there's little point in fixing that either.

It's been decided that this can just be left as is.

comment:5 Changed 6 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:6 Changed 6 years ago by Owen Arnold

I accept this decision

comment:7 Changed 6 years ago by Owen Arnold

  • Status changed from verifying to closed

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11059

Note: See TracTickets for help on using tickets.