Context Navigation

← Previous Ticket
Next Ticket →

Ticket #10246 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Fix os10.9 clang failed tests

Reported by:	Peter Peterson	Owned by:	Steven Hahn
Priority:	major	Milestone:	Release 3.3
Component:	Framework	Keywords:
Cc:		Blocked By:
Blocking:		Tester:	Stuart Campbell

Description (last modified by Steven Hahn) (diff)

Fix the broken tests http://builds.mantidproject.org/view/Develop%20Builds/job/develop_osx-10.9-clang/

Change History

comment:1 Changed 6 years ago by Steven Hahn

Refs #10246. Fixed PythonScriptsTest_IndirectCommonTests

Changeset: 882fafda0fdaf7ec4925c807a696a390a63dcbd2

comment:2 Changed 6 years ago by Nick Draper

Status changed from new to assigned

comment:3 Changed 6 years ago by Steven Hahn

Owner changed from Peter Peterson to Steven Hahn
Status changed from assigned to inprogress

comment:4 Changed 6 years ago by Steven Hahn

Refs #10246. Fixed DataHandlingTest_GroupDetectors2Test

Changeset: 82d930d59bebb1d916e7d3ad449df559ab17c85a

comment:5 Changed 6 years ago by Steven Hahn

Refs #10246. Added space between arguments

Changeset: 1831a217de53f6a2e94df859e7a271b63f8f15ab

comment:6 Changed 6 years ago by Steven Hahn

Re #10246. w/ openmp thows runtime_error, w/o throws invalid_argument

Changeset: f0f0eec6159d9d69e05c786c1a4032147e05700c

comment:7 Changed 6 years ago by Steven Hahn

Refs #10246 Undoing last commit because of errors on other platforms

Changeset: 1ba7e764a1288678834450401c820b5610b85aff

comment:8 Changed 6 years ago by Steven Hahn

Refs #10246 some macros should still be defined even without openmp

Changeset: 3ca16a7677c2f53c72e1d824775c307a1794145a

comment:9 Changed 6 years ago by Steven Hahn

Refs #10246 ThreadPool no longer depends on openmp

Changeset: 933a1545ee4be7433197a2b8f0fec8577df58945

comment:10 Changed 6 years ago by Steven Hahn

Refs #10246 removed extra space

Changeset: d7eb7e90b74c9ccd1cfff593e03bc5dac3c04964

comment:11 Changed 6 years ago by Steven Hahn

Refs #10246 removed register specifier from Mantid code and added Wno-deprecated-register to silence warnings from boost and Qt that we can't control.

Changeset: 586bba59da810f7fc8fe96cbd5573b1d09a92538

comment:12 Changed 6 years ago by Steven Hahn

Refs #10246 fixed DataHandlingTest_LoadVulcanCalFileTest

Changeset: eb8754183ae1cf9445ecb64d15c82040ed226278

comment:13 Changed 6 years ago by Steven Hahn

Refs #10246 Fixed misspelled header guards that created clang warning

Changeset: 91f5ad1137f311021fd68185ef85b089f250cacb

comment:14 Changed 6 years ago by Steven Hahn

Refs #10246. Disable IkedaCarpenterPVTest, fix python tests.

Changeset: 3cb62aadd407d6d99b34b5ee585d1883d698ac16

comment:15 Changed 6 years ago by Steven Hahn

Refs #10246 Reverting ThreadPool.cpp b/c openmp is in logging code

Changeset: bc3b65d33344be8c0131b9ee81c0cb8ac3b4d416

comment:16 Changed 6 years ago by Steven Hahn

Description modified (diff)

For testing, I would suggest building mantid on a OS X 10.9 machine and verifying that all unit tests pass. I would also verify that these changes don't create any errors or warnings on other platforms. One can also remove "-Wno-deprecated-register" from the CXX_FLAGS and verify that the "'register' storage class specifier is deprecated" warning does not come from any Mantid code.

Boost 1.56 breaks Mantid, so use an earlier version installed by homebrew ("brew switch boost 1.55.0_2")

Last edited 6 years ago by Steven Hahn (previous) (diff)