Ticket #10259 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Calibration range calculation

Reported by: Dan Nixon Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By: #10083
Blocking: #10277 Tester: Harry Jeffery

Description

Spencer has provided some code to calculate better default peak and background ranges for Indirect Calibration.

Attachments

calibration_energy.py (1.6 KB) - added by Dan Nixon 6 years ago.

Change History

Changed 6 years ago by Dan Nixon

comment:1 Changed 6 years ago by Dan Nixon

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Dan Nixon

  • Blocked By 10083 added

Some nice instrument loading functions were added in this ticket that would be useful here.

comment:3 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Added new range calculation, needs refactoring

Refs #10259

Changeset: feb2409d38caa785eb2544f8584a87c97f028e2b

comment:4 Changed 6 years ago by Dan Nixon

Use IPF defaults for calibration range

Refs #10259

Changeset: 0f54cd8f9f6f75ae399067b73d757bee3432f9ca

comment:5 Changed 6 years ago by Dan Nixon

Revert the correct funtionality

Refs #10259

Changeset: 683f757b29a9fb47126ec3a9b5a5dc419381bfea

comment:6 Changed 6 years ago by Dan Nixon

Merge branch 'bugfix/10083_inelastic_indirect_reducer_algorithm_refactoring' into feature/10259_new_calibration_range_calculation

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/IndirectCalibration.cpp Code/Mantid/MantidQt/CustomInterfaces/src/IndirectDataReductionTab.cpp

Refs #10259

Changeset: af7205a4cac6c07a44b2badadc34f761ad5c39ef

comment:7 Changed 6 years ago by Dan Nixon

Clean up range function

Refs #10259

Changeset: 36a98f4333fc9d86a5deaf9ca4308ff8fd7bd324

comment:8 Changed 6 years ago by Dan Nixon

Minor changes to instrument param loading

Refs #10259

Changeset: 75d9e107f84d2e6e7731488f731a9471d2bf7b22

comment:9 Changed 6 years ago by Dan Nixon

To test:

  • Open Indirect > Data Reduction > Energy Transfer
  • Ensure IRIS, graphite and 002 are selected
  • Switch to Calibration tab
  • Enter 26173 in the Run No
  • Notice that the calibration peak range includes as little of the background as possible and the background range does not include data outside of the background noise
  • Compare this with the default peak and background ranges used in Mantid 3.2

comment:10 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 6 years ago by Dan Nixon

  • Blocking 10277 added

comment:12 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:13 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge branch 'bugfix/10083_inelastic_indirect_reducer_algorithm_refactoring' into feature/10259_new_calibration_range_calculation

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/IndirectCalibration.cpp Code/Mantid/MantidQt/CustomInterfaces/src/IndirectDataReductionTab.cpp

Refs #10259

Full changeset: af7205a4cac6c07a44b2badadc34f761ad5c39ef

comment:14 Changed 6 years ago by Dan Nixon

Merge branch 'bugfix/10083_inelastic_indirect_reducer_algorithm_refactoring' into feature/10259_new_calibration_range_calculation

Full changeset: 1d76f5d8d822d90998a0cd73eaa6c4ee6527ad49

comment:15 Changed 6 years ago by Dan Nixon

Merge branch 'master' into feature/10259_new_calibration_range_calculation

Full changeset: 103d44dec227bd8572074959bb02e55bb13cbae1

comment:16 Changed 6 years ago by Harry Jeffery

Merge remote-tracking branch 'origin/feature/10259_new_calibration_range_calculation'

Full changeset: 9955525706c23fde2a1052ab941173054b360fb9

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11101

Note: See TracTickets for help on using tickets.