Ticket #10264 (closed: fixed)
Indirect algorithm: slice
Reported by: | Dan Nixon | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | major | Milestone: | Release 3.3 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | spencer.howells@… | Blocked By: | |
Blocking: | #9969, #10299 | Tester: | Alex Buts |
Description
Used in Indirect Data Reduction > Diagnostics
Change History
comment:2 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
Moved time slice to Python algo, added docs
Refs #10264
Changeset: 6af5ff991b61c149ae1dc23293a3cb646e0f1a1a
comment:4 Changed 6 years ago by Dan Nixon
Use a data selctor for calibration file
Refs #10264
Changeset: 69e51d612bdf8ae00cc40a2220ad1a1e59da41e6
comment:5 Changed 6 years ago by Dan Nixon
Modified system test for new TimeSlice algorithm
Refs #10264
Changeset: 59a6ffd2640962925621cb42eec177a25a8df1e6
comment:6 Changed 6 years ago by Dan Nixon
Added grouped output, usage example and unit test
Refs #10264
Changeset: 851c7934e9a7f5b7812c5675a9976a55ae2f21eb
comment:7 Changed 6 years ago by Dan Nixon
Merge branch 'feature/10264_indirect_slice_algorithm' into develop
Conflicts:
SystemTests/AnalysisTests/ISISIndirectInelastic.py
Refs #10264
Changeset: f1120ec4f47d86ced263e0f1243f1168b50ae6b2
comment:8 Changed 6 years ago by Dan Nixon
To test:
- Open Indirect > Data Reduction > Calibration
- Create a calibration workspace for IRIS (select under Instrument on Energy Transfer) using 26173
- Switch to Diagnosics tab
- Check Use Calibration, Workspace, select the workspace just created
- In input files enter 26176
- Enable plot result, run Diagnostics
- Enable Use Two Ranges
- Run again, notice the lower position of the curve on the Y axis, this shows the background has been removed
Note that there are changes to systemtests to go with this ticket.
comment:10 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:11 Changed 6 years ago by Dan Nixon
- Status changed from verify to reopened
- Resolution fixed deleted
comment:12 Changed 6 years ago by Dan Nixon
- Status changed from reopened to inprogress
comment:13 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
comment:15 Changed 6 years ago by Alex Buts
- Status changed from verify to verifying
- Tester set to Alex Buts
comment:16 Changed 6 years ago by Alex Buts
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10264_indirect_slice_algorithm'
Full changeset: b84ad5e82e1c8f85c6cf36c24e4149d981d5c3f9
comment:17 Changed 6 years ago by Alex Buts
Merge remote-tracking branch 'origin/feature/10264_indirect_slice_algorithm'
Full changeset: a06ff5daad62cebe1ed8e0f473a8cd65c4da5f54
comment:18 Changed 6 years ago by Alex Buts
BTW -- indirect reduction generates results which do not have history any more. It does not seems have anything to do with changes in this ticket but the recent release Mantid (3.2.1) does generate history.
As this change looks local to indirect analysis I am not sure if this behaviour is intended/desired or not, so would suggest an instrument scientist or power user responsible for the reduction have a look at it.
I would be very unhappy if direct reduction results do not have history.
comment:19 Changed 6 years ago by Alex Buts
Merge remote-tracking branch 'origin/feature/10264_indirect_slice_algorithm'
Full changeset: b84ad5e82e1c8f85c6cf36c24e4149d981d5c3f9
comment:20 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11106