Ticket #10266 (closed: fixed)
C2E: Instrument configuration should be common to all tabs
Reported by: | Dan Nixon | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | major | Milestone: | Release 3.3 |
Component: | GUI | Keywords: | |
Cc: | spencer.howells@… | Blocked By: | #10306 |
Blocking: | #10278 | Tester: | Harry Jeffery |
Description
Something noted by Vicky and Spencer:
Currently the instrument, analyser and reflection are selected on the Energy Transfer tab, but the values they are set to are used on multiple tabs (at least Calibration).
A better solution would be to move the instrument config out of the tab and place it in a group box below the tabs but above the bottom buttons.
Change History
comment:4 Changed 6 years ago by Dan Nixon
Its more logical to have instrument selection at the top
Refs #10266
Changeset: 4252c594a8fbf6248d09c3a6b81f0db2d18c8cda
comment:7 Changed 6 years ago by Dan Nixon
Merge branch 'master' into feature/10266_idr_instrument_common_to_all_tabs
Refs #10266
Changeset: db5dd6a396856e9f9d88c671fb8348fe2cb33ad0
comment:8 Changed 6 years ago by Dan Nixon
Merge branch 'master' into feature/10266_idr_instrument_common_to_all_tabs
Refs #10266
Changeset: 92f6cf799c0d2d9ee0152a2eb10e8564ec92c158
comment:9 Changed 6 years ago by Dan Nixon
Add instrument changed signal to IDR & tab
Refs #10266
Changeset: c36e2e06147711b1d8af8d56adfbe6865898e674
comment:10 Changed 6 years ago by Dan Nixon
Merge branch 'master' into feature/10266_idr_instrument_common_to_all_tabs
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/IndirectDataReduction.cpp
Refs #10266
Changeset: 25485a5d65e0390f1936c1cad14b45da60fb0c6b
comment:11 Changed 6 years ago by Dan Nixon
Moved inst loading and UI code to IndirectDataReduction
Refs #10266
Changeset: 22ad3e6deb0a2db2ddbde8886a995109bb44bba3
comment:12 Changed 6 years ago by Dan Nixon
Re add trans, symm and moments
They do not care about the instrument
Refs #10266
Changeset: 53fa6287f28c8f63027909203f2a566d52223a8f
comment:13 Changed 6 years ago by Dan Nixon
Re-add SQw, get efixed using getInstrumentDetails()
Refs #10266
Changeset: a5a92d1b162897165f90fa251fd7e785e47274c7
comment:14 Changed 6 years ago by Dan Nixon
comment:15 Changed 6 years ago by Dan Nixon
Re-add calibration, use detector ranges from IPF
Refs #10266
Changeset: 4d0af24b18fbe95d1891736ad4d3024e8c7c0d30
comment:16 Changed 6 years ago by Dan Nixon
comment:17 Changed 6 years ago by Dan Nixon
Auto update instrument details in Calib and Diag
Refs #10266
Changeset: 86fcd61383f6e7868432047d75434cb63be98ddf
comment:18 Changed 6 years ago by Dan Nixon
comment:19 Changed 6 years ago by Dan Nixon
comment:20 Changed 6 years ago by Dan Nixon
Merge branch 'feature/10266_idr_instrument_common_to_all_tabs' into develop
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/IndirectDataReductionTab.cpp
Refs #10266
Changeset: ef2e4cb3da07529fab3f7b5f293556405f51ee38
comment:21 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
To test:
- Open Indirect > Data Reduction
- Change the instrument, analyser and reflection, ensure that only valid combinations are given (see end of comment)
- On energy transfer, calibration and diagnostics change the instrument/analyser and verify the spectra ranges change.
- On calibration and diagnostics ensure the peak and background ranges change.
- On energy transfer ensure the efixed value changes (note, TOSCA should be 0 (or at least the IPF says it should be))
Valid instrument combinations:
- IRIS
- graphite
- 002
- 004
- mica
- 002
- 004
- 006
- fmica
- 002
- 006
- graphite
- OSIRIS
- graphite
- 002
- 004
- graphite
- TOSCA
- graphite
- 002
- graphite
comment:22 Changed 6 years ago by Harry Jeffery
- Status changed from verify to verifying
- Tester set to Harry Jeffery
comment:23 Changed 6 years ago by Dan Nixon
- Status changed from verifying to closed
Merge branch 'master' into feature/10266_idr_instrument_common_to_all_tabs
Refs #10266
Full changeset: db5dd6a396856e9f9d88c671fb8348fe2cb33ad0
comment:24 Changed 6 years ago by Dan Nixon
Merge branch 'master' into feature/10266_idr_instrument_common_to_all_tabs
Refs #10266
Full changeset: 92f6cf799c0d2d9ee0152a2eb10e8564ec92c158
comment:25 Changed 6 years ago by Dan Nixon
Merge branch 'master' into feature/10266_idr_instrument_common_to_all_tabs
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/IndirectDataReduction.cpp
Refs #10266
Full changeset: 25485a5d65e0390f1936c1cad14b45da60fb0c6b
comment:26 Changed 6 years ago by Harry Jeffery
Merge remote-tracking branch 'origin/feature/10266_idr_instrument_common_to_all_tabs'
Full changeset: 7c6863bf4abd1399a1a2c115fbfeb91846f877ac
comment:27 Changed 6 years ago by Dan Nixon
Merge branch 'feature/10266_idr_instrument_common_to_all_tabs' into develop
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/IndirectDataReductionTab.cpp
Refs #10266
Changeset: ef2e4cb3da07529fab3f7b5f293556405f51ee38
comment:28 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11108