Ticket #10289 (closed: fixed)
LoadANSTO and LoadBBY attribute according to code standard
Reported by: | Anders Markvardsen | Owned by: | Anders Markvardsen |
---|---|---|---|
Priority: | minor | Milestone: | Release 3.3 |
Component: | SANS | Keywords: | |
Cc: | davidm@… | Blocked By: | |
Blocking: | Tester: | Karl Palmen |
Description (last modified by Karl Palmen) (diff)
Update LoadANSTOHelpe and LoadBBY attributes to code standard, here changing '_' to 'm_'.
Code standard described here: http://www.mantidproject.org/C%2B%2B_Coding_Standards
Change History
comment:2 Changed 6 years ago by Anders Markvardsen
- Status changed from assigned to inprogress
improvement to code naming. re #10289
David Mannicke changes to code including:
1) attributes renames from using prefix _ to m_ 2) more use of const keyword
Changeset: ba244b87b7c99fbbaf243ab35105f8fa0a289ae0
comment:3 Changed 6 years ago by Anders Markvardsen
- Status changed from inprogress to verify
- Resolution set to fixed
To tester:
1) check that m_ has been replaced by _ attributes
See description of ticket
comment:4 Changed 6 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:5 Changed 6 years ago by Karl Palmen
- Description modified (diff)
LoadANSTO has been renamed LoadANSTOHelper.
comment:6 Changed 6 years ago by Karl Palmen
I note that the BbyDetectorBankFactory class within LoadBBY.cpp still has member variables beginning with '_' rather than 'm_' and some of them are const. However I think changing them is beyond the scope of the ticket.
Also I think, 'm_' member variables not a member of the main class could be confusing.
comment:7 Changed 6 years ago by Karl Palmen
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10289_anstoLoaderAttNameChange'
Full changeset: 9438a3f55b2e138f42bf2e4c77125ad13ac51a7d
comment:8 Changed 6 years ago by Karl Palmen
Merge remote-tracking branch 'origin/feature/10289_anstoLoaderAttNameChange'
Full changeset: 9438a3f55b2e138f42bf2e4c77125ad13ac51a7d