Ticket #10298 (closed: fixed)
DensityOfStates UI
| Reported by: | Dan Nixon | Owned by: | Dan Nixon |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.4 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | Blocked By: | #10782 | |
| Blocking: | Tester: | Harry Jeffery |
Description (last modified by Dan Nixon) (diff)
Add a user interface for the DensityOfStates as a new tab in Indirect > Simulation.
This should give the user a list of all ions in a file and allow them to select a subset for a partial DoS.
Change History
comment:2 Changed 6 years ago by Dan Nixon
- Description modified (diff)
- Blocked By 10782 added
- Milestone changed from Backlog to Release 3.4
comment:3 Changed 6 years ago by Dan Nixon
- Component changed from User Interface to Indirect Inelastic
comment:8 Changed 6 years ago by Dan Nixon
Add cross section scale option to DoS UI
Refs #10298
Changeset: 4158b5ce8721d8c6efa75b5519a6ea3e2bdced79
comment:9 Changed 6 years ago by Dan Nixon
Handle all DoS types, handle plotting
Refs #10298
Changeset: c81a4bc639f8224c17f8284d99e1168a93ad0816
comment:10 Changed 6 years ago by Dan Nixon
Support saving result to default save directory
Refs #10298
Changeset: 03e144cfad1593a4f0e0eda3206c7474845fd530
comment:11 Changed 6 years ago by Dan Nixon
Merge branch 'master' into feature/10298_densityofstates_ui
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/CMakeLists.txt
Refs #10298
Changeset: d10cd089e8c91887a3394311011890206ba98b13
comment:12 Changed 6 years ago by Dan Nixon
Add documentation for DensityOfStates tab
Refs #10298
Changeset: c6ac4476c2ee2f2f952925eb5cf9cb65b75329d4
comment:13 Changed 6 years ago by Dan Nixon
To test:
- Review the indirect simulation documentation page
- Give the UI a try using the squaricn.phonon and squaricn.castep files in systemtests/Data
comment:14 Changed 6 years ago by Dan Nixon
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #164.
comment:15 Changed 6 years ago by anonymous
Can one of the admins verify this patch?
comment:16 Changed 6 years ago by Harry Jeffery
Jenkins, test this please.
comment:17 Changed 6 years ago by Dan Nixon
Merge branch 'master' into feature/10298_densityofstates_ui
Conflicts:
Code/Mantid/MantidQt/CustomInterfaces/src/Indirect/IndirectSimulation.cpp
Refs #10298
Changeset: 42606e9957399382da161f714cdc0634366e656a
comment:18 Changed 6 years ago by Dan Nixon
comment:19 Changed 6 years ago by Dan Nixon
Jenkins, retest this please.
comment:20 Changed 6 years ago by Harry Jeffery
- Status changed from verify to verifying
- Tester set to Harry Jeffery
comment:21 Changed 6 years ago by Harry Jeffery
I've found a few issues:
- Running with Raman against squaricn.phonon yields a Attempt to assign to Property (Temperatue) of incorrect type exception.
- Indentation - If you skim through the diff you'll notice there's some strange indentation going on. Tabs are used in some files entirely, mixed tabs and spaces in others, etc.
- Typo in documentation fatcor: https://github.com/mantidproject/mantid/pull/164/files#diff-b719af76d6bec1255bdd1ad393f155f1R128
Other than the aforementioned, it looks good.
comment:22 Changed 6 years ago by Dan Nixon
Fixed indentation, spelling error and Raman temp
Refs #10298
Changeset: a14e349ed2b73a6cc109bedf4a05c9720086bbc6
comment:23 Changed 6 years ago by Dan Nixon
Jenkins, retest this please.
comment:24 Changed 6 years ago by Harry Jeffery
- Status changed from verifying to closed
Merge pull request #164 from mantidproject/feature/10298_densityofstates_ui
DensityOfStates UI
Full changeset: 85a4f4308466f87dbb136147e2404e1929fcebc0
comment:25 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11140
