Ticket #10357 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Event filter gui - modify load mechanism

Reported by: Peter Peterson Owned by: Wenduo Zhou
Priority: major Milestone: Release 3.3
Component: GUI Keywords:
Cc: Blocked By: #10227
Blocking: Tester: Harry Jeffery

Description

The top of the dialog with the "File Name" label needs to be reworked so people can type in just a string (e.g. PG3_12345) and use that file. The current "Load" button is misleading since it is a "Browse". This should be modified to use the same mnemonics as the Load algorithms.

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Wenduo Zhou

  • Status changed from assigned to inprogress

Refs #10357. Improved loading.

On branch feature/10357_eventfilter_gui_load

modified: Mantid/scripts/FilterEvents/MainWindow.ui modified: Mantid/scripts/FilterEvents/Ui_MainWindow.py modified: Mantid/scripts/FilterEvents/eventFilterGUI.py

Including (1) Changed the label to load file; (2) Enabled to load by run number, nexus file name or instrument_runnumber; (3) Name of output workspace is made consistent as InstrumentShortName_RunNumber_event

modified: Mantid/scripts/FilterEvents.py

An unnecessary output is removed

Changeset: 84aca9c738298c5228e7f67ebdd9b84055703585

comment:3 Changed 6 years ago by Wenduo Zhou

For tester

  1. Check the difference in the label between the old and modified version;
  1. Try to load the data by
    • full path;
    • run number only
    • INSTRUMENTNAME_RUNNUMBER

comment:4 Changed 6 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:6 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10357_eventfilter_gui_load'

Full changeset: 72407578239efbf061e5751a9cc002ceb91826a4

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11199

Note: See TracTickets for help on using tickets.