Ticket #10360 (closed: fixed)
Event filter gui - error messages
Reported by: | Peter Peterson | Owned by: | Wenduo Zhou |
---|---|---|---|
Priority: | major | Milestone: | Release 3.4 |
Component: | GUI | Keywords: | |
Cc: | Blocked By: | #10227 | |
Blocking: | Tester: | Dan Nixon |
Description
In addition to the big "ERROR!" label near the top, give a pop-up with more information for what is wrong. This can be reproduced by loading a histogram into the interface.
Change History
comment:4 Changed 6 years ago by Wenduo Zhou
- Status changed from assigned to inprogress
- Milestone changed from Backlog to Release 3.4
comment:5 Changed 6 years ago by Wenduo Zhou
Refs #10360. Added a dialog box for error message.
On branch feature/10360_evtfilter_gui_errormsg
- new file: ErrorMessage.ui
- new file: Ui_ErrorMessage.py
- modified: eventFilterGUI.py
Changeset: 84762f3737634104b0d155ce5d6a34f661c2f78f
comment:6 Changed 6 years ago by Wenduo Zhou
Minor change in error dialog. Refs #10360.
Changeset: bc27eb5dfb84fb93e98b4a16f4127f0111abbfa7
comment:7 Changed 6 years ago by Wenduo Zhou
Enabled auto-expansion of error dialog. Refs #10360.
Changeset: 1de88a9ec002e3149fa9fc9803f11790a18eafbd
comment:8 Changed 6 years ago by Wenduo Zhou
Refs #10360. Made GUI scalable.
On branch feature/10360_evtfilter_gui_errormsg
- new file: MplFigureCanvas.py, a customized Qt-matplot widget for plot
- modified: MainWindow.ui
- modified: Ui_MainWindow.py
- modified: eventFilterGUI.py
Changeset: ca12230e0f8c401ba51d32761d79ac5c81022eac
comment:9 Changed 6 years ago by Wenduo Zhou
Refs #10360. cleaned up codes.
Changeset: 70d50849792e6af1d561a6141f9a717f3b54cbc7
comment:10 Changed 6 years ago by Wenduo Zhou
Refs #10360. Improved main UI to be scalable.
On branch feature/10360_evtfilter_gui_errormsg
- modified: MainWindow.ui
- modified: Ui_MainWindow.py
- modified: eventFilterGUI.py (enabled to pop an error window)
Changeset: a8f338c56aefd47299c7c72a84e105bd2c015d11
comment:11 Changed 6 years ago by Wenduo Zhou
For tester
Here is the change from this ticket:
- A pop-up dialogue box is implemented for error encountered;
- The big error message is removed due to the introduction of pop-up dialogue for error message;
- The GUI widgets are put to layouts such that the window can be expanded and contracted.
In order to test it, you may (1) review the change of the code; (2) input a random integer number as a non-existing run number and press 'Load'. An error message will be popped out then. (3) Make the GUI window larger and smaller to see that it scales.
comment:12 Changed 6 years ago by Wenduo Zhou
Refs #10360. Fixed an issue to clear log name after loading.
Changeset: 75cb02c363b473736b387452d5e19988d1dfcc20
comment:13 Changed 6 years ago by Wenduo Zhou
- Status changed from inprogress to verify
- Resolution set to fixed
comment:14 Changed 6 years ago by Dan Nixon
- Status changed from verify to verifying
- Tester set to Dan Nixon
comment:15 Changed 6 years ago by Dan Nixon
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10360_evtfilter_gui_errormsg'
Full changeset: 153c21aae51e780a22ac9211a55d91688886e8d6
comment:16 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11202