Ticket #10372 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Prompt user before discarding table

Reported by: Harry Jeffery Owned by: Harry Jeffery
Priority: major Milestone: Release 3.3
Component: Reflectometry Keywords:
Cc: Blocked By: #10364
Blocking: Tester:

Description (last modified by Harry Jeffery) (diff)

In the new Refl UI, if the user opens an existing table or tries to start a new table they will lose any changes made to their current table. The UI should prompt the user, asking them if they wish to save their changes first.

Change History

comment:1 Changed 6 years ago by Harry Jeffery

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Harry Jeffery

  • Description modified (diff)

comment:3 Changed 6 years ago by Harry Jeffery

  • Blocked By 10364 added

comment:4 Changed 6 years ago by Harry Jeffery

  • Status changed from assigned to inprogress

comment:5 Changed 6 years ago by Harry Jeffery

Refs #10372 Ask user before discarding changes

Changeset: 935e8b52ba5f3adddfda818868926107d7284038

comment:6 Changed 6 years ago by Harry Jeffery

Merge branch 'master' into feature/10372_prompt_before_discard_table

Refs #10372

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/ReflMainViewPresenter.cpp

Changeset: 414bfa995900ae13e69a6918ef0b565570703261

comment:7 Changed 6 years ago by Harry Jeffery

Refs #10372 Add unit tests for prompt before discarding

Changeset: 31ebbbcba8ec10badac792e1a87e6c89465824dd

comment:8 Changed 6 years ago by Harry Jeffery

  • Status changed from inprogress to verify
  • Resolution set to fixed

Testing

  1. Start a new table
  2. Make changes
  3. Try to start a new table. You'll be asked if you're sure you want to discard your changes.
    • Verify both responses behave as you would expect
  4. Save
  5. Try to start a new table. You should not be prompted, it should just work.
  6. Make changes again.
  7. Try to open a table (such as the one you just saved). You should be prompted about unsaved changes.
    • Verify both responses behave as you would expect

And the old favourites:

  • Verify unit tests are passing
  • Inspect code

comment:9 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to closed

Merge branch 'master' into feature/10372_prompt_before_discard_table

Refs #10372

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/ReflMainViewPresenter.cpp

Full changeset: ​414bfa995900ae13e69a6918ef0b565570703261

comment:10 Changed 6 years ago by Owen Arnold

Merge remote-tracking branch 'origin/feature/10372_prompt_before_discard_table'

Full changeset: ​a7d16ea1318177df346dc12a946953f0b93cde2f

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11214

Note: See TracTickets for help on using tickets.