Ticket #10373 (closed: fixed)
Refl UI - Provide actions in a context menu
Reported by: | Harry Jeffery | Owned by: | Harry Jeffery |
---|---|---|---|
Priority: | minor | Milestone: | Release 3.3 |
Component: | Reflectometry | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Dan Nixon |
Description
It would be nice if users were able to right click on a row (or a selection of rows) and be provided with a context menu with these options:
- Insert row before
- Insert row after
- Delete row(s)
- Group row(s)
- Process row(s)
Change History
comment:3 Changed 6 years ago by Harry Jeffery
- Blocked By 10349 added
Waiting on #10349 to pass testing to avoid a merge conflict.
comment:4 Changed 6 years ago by Federico M Pouzols
- Blocked By 10349 removed
(In #10349) It's working. The code is well organized and documented. It also comes with new unit tests.
- If I forget any member of a group in my selections, the GUI will warn me when I click 'Process'.
- Unit tests pass.
I noticed a minor GUI issue that can be annoying. If you resize the table columns and then run 'Process', the column sizes are reset. It seems that hte properties of most if not all the form widgets are reset.
I also noticed that if you try to run it with instruments other than INTER (I tried SURF), it will crash. I guess this is under development at this stage.
comment:5 Changed 6 years ago by Harry Jeffery
Refs #10373 Add context menu to Refl UI table
Changeset: 230ea923887b7184c353eae05b4e345f5197b32a
comment:6 Changed 6 years ago by Harry Jeffery
Refs #10373 Add icon to Open Table items
Changeset: 7590987baf8c24bccd5ec61a5fb1da1dd8e302a8
comment:7 Changed 6 years ago by Harry Jeffery
Refs #10373 Add process to context menu
Changeset: 8c468eaa0ec5a71250976820e96f4a45a5ba2ca9
comment:8 Changed 6 years ago by Harry Jeffery
Refs #10373 Split AddRow → AppendRow/PrependRow
Changeset: 2c041f1dd38d49eb5fa4c911b89f27d3d3870f16
comment:9 Changed 6 years ago by Harry Jeffery
Refs #10373 Improve context menu
- Reposition GroupRows
- Add AppendRow
- Add PrependRow
- Add ExpandSelection
Changeset: 758af2e59ccc28c3b2bd3e02209327327710763f
comment:10 Changed 6 years ago by Harry Jeffery
Refs #10373 Add Row menu to menubar
Changeset: b2eec60913dde18c505e257af933be3f1a9513dd
comment:11 Changed 6 years ago by Harry Jeffery
Refs #10373 Update unit test for ReflMainViewPresenter
Changeset: 922a18db2596a6550ab11a42a6350e64d17ab392
comment:12 Changed 6 years ago by Harry Jeffery
Refs #10373 Test prepending rows
Changeset: 8ccd13f3c2296d54b41bec073cceb00b0aca05ff
comment:13 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
Testing
This one's fairly self explanatory from the ticket's description.
- Play with the context menu. Make sure it works.
- Verify unit tests are passing
- Inspect code
Branch: https://github.com/mantidproject/mantid/compare/feature/10373_refl_ui_context_menu
comment:14 Changed 6 years ago by Harry Jeffery
Refs #10373 Remove unused variable
Changeset: 4af46c03a570a868a4897c11b63d724c9e581371
comment:15 Changed 6 years ago by Dan Nixon
- Status changed from verify to verifying
- Tester set to Dan Nixon
comment:16 Changed 6 years ago by Dan Nixon
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/10373_refl_ui_context_menu'
Full changeset: cfc762345e2c97b5b44bcc6520b825ff489257e3
comment:17 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11215