Ticket #10349 (closed: fixed)
Group/Stitch processing warning
Reported by: | Owen Arnold | Owned by: | Harry Jeffery |
---|---|---|---|
Priority: | major | Milestone: | Release 3.3 |
Component: | Reflectometry | Keywords: | |
Cc: | Blocked By: | #10364 | |
Blocking: | Tester: | Federico M Pouzols |
Description
If you select rows in the new reflgui for processing, and those rows do not encompass ALL rows corresponding to that stitching group, then we should warn about this.
As I think unhelpful message boxes are very annoying, it would be even better if there were ways of it then selecting all the group so that you could continue processing with minimal clicks.
Better yet. To avoid doing the manual selection yourself. It would be great if the group selection did this for you. i.e. select all rows corresponding with my current group.
Change History
comment:10 Changed 6 years ago by Harry Jeffery
This commit has been deleted.
comment:11 Changed 6 years ago by Harry Jeffery
This commit has been deleted.
comment:12 Changed 6 years ago by Harry Jeffery
Refs #10349 Rename processRow → reduceRow
Let's increase clarity here. Reducing is running ReflectometryReductionOne. Stitching is running Stitch2D. Processing is reducing AND then stitching.
Changeset: 710bd8caf0485b28d6985a0396b8ffdd041c2239
comment:13 Changed 6 years ago by Harry Jeffery
Refs #10349 Allow non-contiguous selections
Changeset: d1feaa9dc358520819ca516b7f2238034c49d5a2
comment:14 Changed 6 years ago by Harry Jeffery
Refs #10349 Add numRowsInGroup method
This method counts how many rows there are in a particular group.
Changeset: 79b21b500beaae938e47b1358b88f8dd0ae80b9f
comment:15 Changed 6 years ago by Harry Jeffery
Refs #10349 Warn when user tries to partially process a group
Changeset: aaffae54953685b2b1439716110ac118166428a6
comment:16 Changed 6 years ago by Harry Jeffery
Refs #10349 Change selectedRows container to set
Changeset: dc92620cd9c270f30109ffd6aaed42bee97e0112
comment:17 Changed 6 years ago by Harry Jeffery
Refs #10349 Add setSelection method to ReflMainView
Changeset: 9cd204c7617078ab11c1bd7e6257b1499a534311
comment:18 Changed 6 years ago by Harry Jeffery
Refs #10349 Add expandSelection action to Refl UI
Changeset: b593cd9ed9746fbba0d0a2499fb38986f56d24a9
comment:19 Changed 6 years ago by Harry Jeffery
Refs #10349 Unit test selection expansion
Changeset: 23a40a80758c1f8772b78d277d2338dc794b7a48
comment:20 Changed 6 years ago by Harry Jeffery
Todo: Preserve the user's selection whenever the table is updated.
comment:21 Changed 6 years ago by Harry Jeffery
Refs #10349 Resolve cppcheck warning
Changeset: 0a660e9bcc147ed5ac52b52447001df50b34adcf
comment:22 Changed 6 years ago by Harry Jeffery
Refs #10349 Check for partial group processing early
We don't want to do any loading/validation/autofilling before we've checked for partial processing of a group
Changeset: ab8759ae21fd973b6edcc6dcfe04c2de6d89f484
comment:23 Changed 6 years ago by Harry Jeffery
Refs #10349 Use a set of rows instead of vector
In this case, std::set is more appropriate than std::vector.
Changeset: 4fe99d9ba85c5c8c4c3c2652c0be715931c98e47
comment:24 Changed 6 years ago by Harry Jeffery
- Status changed from inprogress to verify
- Resolution set to fixed
Testing
- Create half a dozen or so rows in the new Refl UI.
- Group them into a few different groups of various sizes
- Select part of a group and hit process. You should be warned that you're only partially processing a group.
- Select an entire group and hit process. You should not be warned.
- Try using the "expand selection" button. It should always expand your selection to contain all the rows of any group you have selected.
- Keep playing until you're satisfied.
- Verify unit tests are passing.
- Inspect changes.
Branch: https://github.com/mantidproject/mantid/compare/feature/10349_stitch_processing_warning
comment:25 Changed 6 years ago by Federico M Pouzols
- Status changed from verify to verifying
- Tester set to Federico M Pouzols
comment:26 Changed 6 years ago by Harry Jeffery
- Blocking 10373 added
comment:26 Changed 6 years ago by Federico M Pouzols
- Status changed from verifying to closed
- Blocking 10373 removed
It's working. The code is well organized and documented. It also comes with new unit tests.
- If I forget any member of a group in my selections, the GUI will warn me when I click 'Process'.
- Unit tests pass.
I noticed a minor GUI issue that can be annoying. If you resize the table columns and then run 'Process', the column sizes are reset. It seems that hte properties of most if not all the form widgets are reset.
I also noticed that if you try to run it with instruments other than INTER (I tried SURF), it will crash. I guess this is under development at this stage.
comment:28 Changed 6 years ago by Federico Montesino Pouzols
Merge remote-tracking branch 'origin/feature/10349_stitch_processing_warning'
Full changeset: c80a9970c74659350a6370c725cf64f044b8c877
comment:29 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11191