Ticket #10374 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

NXTomo Save Algorithm Improvements

Reported by: John Hill Owned by: John Hill
Priority: major Milestone: Release 3.3
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Raquel Alvarez Banos

Description (last modified by John Hill) (diff)

SaveNXTomo Alg:

•Write additional workspace properties into the file.

•Look for and record correct beam intensity information. ('Intensity' log value)

•Look for and record correct rotational information. ('Rotation' log value)

•Look for and record the correct key for an image ('ImageKey' log value)

•Include unit test

LoadFITS Alg:

•Add a parameter to indicate which 'ImageKey' metadata value should be set for a workspace when loaded. This is to differentiate between open/flat field images and sample data images.

Testing:

•Check that LoadFITS alg with AutoTestData/FITS_small_01.fits loads data into a workspace (Set ImageKey property on the load dialogue to 0 or the load will fail)

•Run SaveNXTomo alg on the workspace, and check it saves a file.

•Open it in HDFView and check that entry1/tomo_entry/instrument/detector -> image_key contains a zero value (same as entered when loading the FITS file).

•Check the SaveNXTomoTest test seems sensible and completes in a timely manner.

Change History

comment:1 Changed 6 years ago by John Hill

  • Description modified (diff)

comment:2 Changed 6 years ago by John Hill

  • Description modified (diff)
  • Blocked By 10519 added
  • Milestone changed from Backlog to Release 3.3

comment:3 Changed 6 years ago by John Hill

Refs #10374 adding unit test and support for image keys

Changeset: e67387e6abf112b700e6a9317e627694639926c8

comment:4 Changed 6 years ago by John Hill

Refs #10374 attempting to fix build error

Changeset: f66908e53f733ca9c64e22c875a000b7e64d8ad3

comment:5 Changed 6 years ago by John Hill

Refs #10374 correcting includes

Changeset: 60ee0927611e7249551b389cc685e7bd6d56116a

comment:6 Changed 6 years ago by John Hill

Refs #10374 osx test fix

Changeset: e06ed9ba759525a19e5f042e7eda8cb7cd936d23

comment:7 Changed 6 years ago by John Hill

Refs #10374 warning fix

Changeset: ba6d92b0b5d0a4d7191fbbf964f15eca397b8a6d

comment:8 Changed 6 years ago by John Hill

  • Status changed from new to assigned

comment:9 Changed 6 years ago by John Hill

  • Status changed from assigned to inprogress
  • Description modified (diff)

comment:10 Changed 6 years ago by John Hill

  • Blocked By 10519 removed

comment:11 Changed 6 years ago by John Hill

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:12 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez Banos

comment:13 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10374_fits_nxtomo_beam_data'

Full changeset: ​5b370642be06b41072cd72bc6181980019c5507a

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11216

Note: See TracTickets for help on using tickets.