Use menubar in Refl UI

[Harry Jeffery]

To prepare for creating an options menu for the Refl UI, we should first have a menu bar to launch the options menu from.

The goal of this ticket is to create a menu bar and populate it appropriately with relevant actions.

[Harry Jeffery]

Refs #10376 Assign icons to actions

Changeset: b1a1caebd6bdb0085e44d33d96a7d371b1b600b5

[Harry Jeffery]

Refs #10376 Move New, Save, and Save As to menu bar

Changeset: 2d83e07f5f77d66a380830704f702cebac0c5358

[Harry Jeffery]

Refs #10376 Change some PushButtons to ToolButtons

• Add Row
• Delete Row
• Group Rows

Changeset: b62b3fc77084321230d2140868fd38043453203d

[Harry Jeffery]

Refs #10376 Provide a menu for opening tables

This commit removes the workspace selector in favour of providing a proper menu for opening tables.

Changeset: 14c455ef659566a5702f71a768980f22f629bf39

[Harry Jeffery]

Refs #10376 Update ReflMainViewPresenter unit test

• Add expectations for setTableList
• Remove unnecessary check points. setTableList was being called many times after a checkpoint (which had cleared expectations), causing many uninteresting calls to setTableList to issue warnings.

Changeset: acc0692f5f5971140e28cdc3d3c029e2a2f34991

[Harry Jeffery]

Refs #10376 Reduce initial Refl UI size

Changeset: 87d91d85c133bff2d8d3b7083f818e35eef58332

[Harry Jeffery]

Testing

• Open the Refl UI
• Play with the new menu bar
  • Verify all the menu actions work
  • Verify the add row, remove row, and group row tool buttons work
• Verify unit tests are passing
• Inspect code

[Owen Arnold]

The Menu options are not appearing on OSX. Can you investigate why this might be please.

[Owen Arnold]

Merge remote-tracking branch 'origin/feature/10376_refl_ui_menu_bar'

Full changeset: ​f2a383e23964f2b2cd30a35ebae45a41b8505bf1

[Harry Jeffery]

Refs #10376 Disable Refl UI native menu bar on OSX

Changeset: b16c6e6bd7f6724901776b34aa2e3f9d39dde666

[Owen Arnold]

Application menubar

[Owen Arnold]

I've had some time to look at this issue. The last commit b16c6e6bd7f6724901776b34aa2e3f9d39dde666 enabled, the menu bars in the current window, but what we really need to achieve is use of the system menu bar because this is how most applications behave on OSX, including such tools as the SliceViewer.

​http://qt-project.org/doc/qt-4.8/qmenubar.html suggests that this is down to the way that the menubar is constructed. So one route to try would be to follow the guidance in section QMenuBar on Mac OS X regarding the construction, and try assembling the menubar programatically.

Also:

• Save Table is really an export as workspace feature, and should be labeled and iconed as such.
• Open table did nothing
• New Table did not prompt me to save an existing modified table before loading a new one.

[Harry Jeffery]

THIS COMMIT HAS BEEN REMOVED

Refs #10376 Try creating menu bar programatically

Changeset: 4724bb6f97ddc2b6c3a37cce844d24d31216224d

[Harry Jeffery]

THIS COMMIT HAS BEEN REMOVED

Refs #10376 Create menu bar parentlessly on OSX

Changeset: a871925e097a243d43eb6637add5328791f66736

[Owen Arnold]

I haven't succeeded in getting this to work fully on OSX, and still strongly suspect that this comes down to the way that things are handled in USERSUBWINDOW. However, we can at least provide the menus, even if they end up on the window itself. The only thing left to do here is to call

menuBar->setNativeMenuBar(false); 

in

void QtReflMainView::initLayout()

and this should work sufficiently well in OSX.

[Harry Jeffery]

Merge branch 'master' into feature/10376_refl_ui_menu_bar

Refs #10376

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/ReflMainViewPresenter.cpp

Changeset: dca08edccbba13ffb7fecc9bbed6e548e4cdae40

[Harry Jeffery]

Merge branch 'master' into feature/10376_refl_ui_menu_bar

Refs #10376

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/src/ReflMainViewPresenter.cpp

Full changeset: ​dca08edccbba13ffb7fecc9bbed6e548e4cdae40

[Owen Arnold]

Merge remote-tracking branch 'origin/feature/10376_refl_ui_menu_bar'

Full changeset: ​c7be7f68a707adacb4f02991db9c4cf262dd7175

[Harry Jeffery]

Refs #10376 Try creating menu bar programatically

Changeset: 4724bb6f97ddc2b6c3a37cce844d24d31216224d

[Harry Jeffery]

Refs #10376 Create menu bar parentlessly on OSX

Changeset: a871925e097a243d43eb6637add5328791f66736

[Stuart Campbell]

This ticket has been transferred to github issue ​11218