Ticket #10397 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Modify FITS and NXTomo load/save algorithms for new files

Reported by: John Hill Owned by: John Hill
Priority: minor Milestone: Release 3.3
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Federico M Pouzols

Description (last modified by John Hill) (diff)

Make some changes to the two algorithms to work with the new files released which include rotational information.

This is an interim change as further work is still to be done in these areas once the FITS structure is finalised.

Testing:

• Try to load all attached example files at once (select the two .fits and single .txt file together in load dialogue).

• Save the created workspace with SaveNXTomo algorithm

• Open the saved file in DAWN or HDFView and look for entry1->tomo_entry->data->rotation_angle - this should have the rotation values 0 and 4.5

Attachments

data000.fits (1.0 MB) - added by John Hill 6 years ago.
data001.fits (1.0 MB) - added by John Hill 6 years ago.
Image_TomoAngles.txt (17 bytes) - added by John Hill 6 years ago.

Change History

comment:1 Changed 6 years ago by John Hill

Refs #10397 making changes to handle rotation file

Changeset: 4d7a4fc50145e74d0f77eb071076b21467465b4d

comment:2 Changed 6 years ago by John Hill

Refs #10397 attempting to fix osx build

Changeset: f4bba382b8567559dd9fb562e675e02e7e86c42f

comment:3 Changed 6 years ago by John Hill

  • Status changed from new to assigned

comment:4 Changed 6 years ago by John Hill

  • Status changed from assigned to inprogress

Refs #10397 squashing cppcheck warning

Changeset: 971717dbb25e54a84a79b9b8d39dbe2e87db2f32

comment:5 Changed 6 years ago by John Hill

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Description modified (diff)

Changed 6 years ago by John Hill

Changed 6 years ago by John Hill

Changed 6 years ago by John Hill

comment:6 Changed 6 years ago by John Hill

  • Description modified (diff)

comment:7 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:8 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

It works, the file opens correctly in HDFView, and the rotation data are correct.

The new/changed code is well organized and documented.

comment:9 Changed 6 years ago by Federico Montesino Pouzols

Merge remote-tracking branch 'origin/feature/10397_fits_update'

Full changeset: abfffadccdc3c881b855becf7d0e415686dde6dc

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11239

Note: See TracTickets for help on using tickets.