Ticket #10405 (closed: fixed)

Opened 6 years ago

Last modified 6 years ago

Save new instrument variables sent from the form

Reported by: MarcusNoble Owned by: MarcusNoble
Priority: critical Milestone: Release 3.3
Component: Tools Keywords: AUTOREDUCTION
Cc: doucetm@…, tom.griffin@…, nick.draper@…, anders.markvardsen@… Blocked By:
Blocking: Tester: Anders Markvardsen

Description (last modified by MarcusNoble) (diff)

  • Handle the POST request from the instrument variables page and save new instrument variables for the provided run range.
  • Implement validation. This should be done on both the client and server.
  • Implement the "After run range" choices Decided to simply use default values to avoid confusion.
  • Improve form to better handle the different value types (e.g. currently no boolean support)
  • Add notification when replacing values
  • Handle edits (using script from the DB rather than file)
  • Confirm on leave if changes have been made
  • Reset to default values

For Tester:

Note: Permissions may need to be altered for this to work as expected.

  1. Navigate to ​http://datareducedev.isis.cclrc.ac.uk/autoreduce_webapp/instrument/GEM/ (logging in if needed).
  2. Click the "Add new run variables" link
  3. Enter some text into one of the numerical entries.
  4. Click "Submit Changes"
  5. Check that the numerical box with text is now highlighted red and that the form didn't submit.
  6. Correct the mistake.
  7. Click "Preview reduction script"
  8. Verify that the values in the downloaded script match those in the form.
  9. Click the "Reset to default values"
  10. Verify that all changed values have reverted back to the default.
  11. Click "Submit Changes"
  12. You may or may not get a notification about conflicts (depending on the run start/finish you selected and other saved variables). If you do it is OK to continue.
  13. Verify that the variables you entered now show on the instrument summary page.

Change History

comment:1 Changed 6 years ago by MarcusNoble

  • Status changed from new to assigned

comment:2 Changed 6 years ago by MarcusNoble

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by MarcusNoble

  • Description modified (diff)

comment:4 Changed 6 years ago by MarcusNoble

  • Description modified (diff)

comment:5 Changed 6 years ago by MarcusNoble

  • Description modified (diff)

comment:6 Changed 6 years ago by MarcusNoble

  • Description modified (diff)

comment:7 Changed 6 years ago by MarcusNoble

  • Description modified (diff)

comment:8 Changed 6 years ago by MarcusNoble

  • Description modified (diff)

comment:9 Changed 6 years ago by MarcusNoble

  • Description modified (diff)

comment:10 Changed 6 years ago by MarcusNoble

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Description modified (diff)

comment:11 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:12 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Works as described.

Separate to this ticket shown that All runs serve not working from my account

Note: See TracTickets for help on using tickets.