Ticket #10465 (closed: wontfix)
make sfCalculator work with new detector geometry
| Reported by: | Jean Bilheux | Owned by: | Jean Bilheux |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.3 |
| Component: | Reflectometry | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Peter Peterson |
Description
Attachments
Change History
comment:2 Changed 6 years ago by Jean Bilheux
- Status changed from assigned to inprogress
Fixed issue. This refs #10465
Changeset: ddd2263bc781f690a8aa0e8f458c18f0a78b50bd
Changed 6 years ago by Jean Bilheux
- Attachment REFLSF_test_config.xml added
config file to load into sfCalculator to test ticket
comment:3 Changed 6 years ago by Jean Bilheux
- Status changed from inprogress to verify
- Resolution set to fixed
In order to test this ticket, one must go to lrac (to give access to all the REF_L NeXus files). Load in the sfCalculator GUI the following attached file select a new Scaling Factor File Name -> a folder the program can access and just hit REDUCE Once the reduction is done, REFRESH button and the you should see the following content in the text field
IncidentMedium=Air LambdaRequested=9.06 S1H=0.31 S2H=20.00 S1W=20.01 S2W=30.00 a=2.11208178408 b=-3.56901509591e-06 error_a=0.106166532404 error_b=3.12928987016e-06
comment:6 Changed 6 years ago by Peter Peterson
- Status changed from verify to verifying
- Tester set to Peter Peterson
comment:7 Changed 6 years ago by Peter Peterson
- Status changed from verifying to reopened
- Resolution fixed deleted
I still get an error just running the provided state.
Traceback (most recent call last):
File "[build area]/scripts/Interface/reduction_gui/instruments/interface.py", line 200, in reduce
self.scripter.apply()
File "[build area]/scripts/Interface/reduction_gui/reduction/reflectometer/refl_sf_calculator.py", line 195, in apply
raise RuntimeError, sys.exc_value
NameError: name 'sys' is not defined
comment:8 Changed 6 years ago by Jean Bilheux
- Status changed from reopened to verify
- Resolution set to wontfix
The fix of this ticket is part of ticket #10609.
comment:10 Changed 6 years ago by Peter Peterson
- Status changed from verifying to closed
- Blocking 10609 removed
This one is being orphaned, but I'm not deleting the branch until #10609 is merged into master.
comment:11 Changed 6 years ago by Pete Peterson
Merge remote-tracking branch 'origin/feature/10465_sfCalculator_new_geometry'
Full changeset: d37fec1322e1513d884fb1bb887d5deb90552c9a
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11307
