Ticket #10480 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Saving fitting parameters using SaveParameterFile

Reported by: Anders Markvardsen Owned by: Raquel Alvarez Banos
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: John Hill

Description

To reproduce:

  1. Load AutoTestData\UsageData\HRP39180.RAW
  1. Run SaveParameterFile for this created workspace in 1

The output is e.g. for fitting parameter S:

		<parameter name="S">

			<value val="0 , BackToBackExponential , S ,  ,  ,  ,  , sqrt(188.149*centre^4+6520.945*centre^2) , dSpacing , TOF , linear ; TOF ; TOF"/>

		</parameter>

However it should be:

  <parameter name="BackToBackExponential:S" type="fitting">
    <formula eq="sqrt(7.429*centre^4+132.188*centre^2)" unit="dSpacing" result-unit="TOF" />
  </parameter> 

Change History

comment:1 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from assigned to inprogress

Re #10480 Saving fitting parameters

Changeset: e3519496f6cf86fc541372547f1d0da3453fc84d

comment:3 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from inprogress to verify
  • Resolution set to fixed

Added block to handle fitting parameters in SaveParameterFile. Added unit test for fitting parameters.

For testing (as specified in the ticket description):

  • Load AutoTestData\UsageData\HRP39180.RAW
  • Execute SaveParameterFile algorithm
  • Check the output file is as expected for parameter S and for the other parameters
  • Additionally, check that output stays the same for non-fitting parameters, you may want to try different datasets, for instance I tried AutoTestData/ARCS_2963.nxs, AutoTestData/HET15869.raw, AutoTestData/MUSR00022725.nxs.

comment:4 Changed 6 years ago by John Hill

  • Status changed from verify to verifying
  • Tester set to John Hill

comment:5 Changed 6 years ago by John Hill

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/10480_saving_fitting_parameters'

Full changeset: 7691cf3d36716f1527a6acbe075aeb94f58358d1

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11322

Note: See TracTickets for help on using tickets.