Ticket #10484 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Link on Paraview setup screen is wrong

Reported by: Nick Draper Owned by: Nick Draper
Priority: major Milestone: Release 3.3
Component: GUI Keywords:
Cc: Blocked By: #10322
Blocking: Tester: Federico M Pouzols

Description

the download link pointes to our old download site

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from assigned to inprogress

re #10484 change link to the base download site

Changeset: 634c777f3e4fd1fa722c7710a8e6942e1cfcf762

comment:3 Changed 6 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

to test

  1. Open the setup paraview window from the help menu
  2. check the link for downloading paraview takes you to download.mantidproject.org

comment:4 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:5 Changed 6 years ago by Federico M Pouzols

This works well, and the changeset is simple enough to be 100%? sure there'll be no issues. However I noticed that the branch feature/10484_fix_bad_paraview_link includes additional changes that are totally unrelated to this ticket (those re #10322, see: https://github.com/mantidproject/mantid/compare/feature/10484_fix_bad_paraview_link). Before passing this ticket, could you please confirm if this was intentional? I'd say that the changes to DirectoryValidator.cpp should go out of this branch, but I might be missing something.

Incidentally, I think that this may also fix #10296 in one shot.

While checking this ticket I realized that the current status of the URLs used in the Mantid code is, errr, not so good, so I created ticket #10490.

comment:6 Changed 6 years ago by Martyn Gigg

  • Blocked By 10322 added

Federico is correct. This been based on #10322 by accident.

I have added #10322 as a blocker so that it has to be merged first to avoid any issues.

comment:7 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

Sorted out!

comment:8 Changed 6 years ago by FedeMPouzols

Merge remote-tracking branch 'origin/feature/10484_fix_bad_paraview_link'

Full changeset: 11c1b7ad7a9a540c74f7316fcd85c506a00d4e2e

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11326

Note: See TracTickets for help on using tickets.