fix performance of GeometryTest.ParameterMapTestPerformance

[Steven Hahn]

The specific list of impacted tests are:

test_Inst_Par_Lookup_Via_GetRecursive_And_Leaf_Component 0.0240 -> 0.0265 seconds/iteration

test_Leaf_Par_Lookup_Via_GetRecursive_And_Leaf_Component 0.0132 -> 0.0140 seconds/iteration

test_Leaf_Par_Lookup_Via_Get_And_Leaf_Component 0.0130 -> 0.0139 seconds/iteration

This was introduced in performance build 527 with ​https://github.com/mantidproject/mantid/commit/f94f814ce5e1d89785aece20fa280c2963b94b40

[Steven Hahn]

baseline "totalTime" on my computer:
test_Inst_Par_Lookup_Via_GetRecursive_And_Leaf_Component 0.008089 seconds test_Leaf_Par_Lookup_Via_GetRecursive_And_Leaf_Component 0.002777 seconds test_Leaf_Par_Lookup_Via_Get_And_Leaf_Component 0.002681 seconds

change component_map and pmap from unordered_multimap to multimap test_Inst_Par_Lookup_Via_GetRecursive_And_Leaf_Component 0.007839 seconds test_Leaf_Par_Lookup_Via_GetRecursive_And_Leaf_Component 0.002666 seconds test_Leaf_Par_Lookup_Via_Get_And_Leaf_Component 0.00265 seconds

change boost::tie to std::tie test_Inst_Par_Lookup_Via_GetRecursive_And_Leaf_Component 0.007783 seconds test_Leaf_Par_Lookup_Via_GetRecursive_And_Leaf_Component 0.002586 seconds test_Leaf_Par_Lookup_Via_Get_And_Leaf_Component 0.002528 seconds

remove std::tie test_Inst_Par_Lookup_Via_GetRecursive_And_Leaf_Component 0.007597 seconds test_Leaf_Par_Lookup_Via_GetRecursive_And_Leaf_Component 0.002556 seconds test_Leaf_Par_Lookup_Via_Get_And_Leaf_Component 0.002553 seconds

for best performance, revert all back to the ways things were.

[Steven Hahn]

Refs #10487. Changed back to std::multimap and now using std::tie

Changeset: 105f0619b13a7df3f0f9fa99699d40f0f201ba7f

[Steven Hahn]

Refs #10487. reverted all changes to ParameterMap

Changeset: f3ea699367d012eafd34827775f0a48f383a1f9a

[Steven Hahn]

Refs #10487. cleanup white space

Changeset: 40151811625486c201c095ba3e4f646d35c6924d

[Steven Hahn]

This is being verified as ​pull request #59.

[Martyn Gigg]

I can see a small improvement in the performance tests that are running on develop so this seems to have got it back to where it was.

[Martyn Gigg]

Merge pull request #59 from mantidproject/feature/10487_fix_performance_of_GeometryTest

Full changeset: ​74d9bbfe398e285ee883c71228af9c28ae4d58b6

[Stuart Campbell]

This ticket has been transferred to github issue ​11329