Ticket #10497 (reopened)

Opened 6 years ago

Last modified 6 years ago

Handle scripts that don't expose any variables

Reported by: MarcusNoble Owned by: Lottie Greenwood
Priority: minor Milestone: Backlog
Component: Tools Keywords: AUTOREDUCTION
Cc: doucetm@…, tom.griffin@…, nick.draper@…, anders.markvardsen@… Blocked By:
Blocking: Tester: Anders Markvardsen

Description (last modified by MarcusNoble) (diff)

Currently the webapp is unable to trigger a reduction job if the reduction file doesn't expose any variables.

This needs changing to make it easier to get people on board with the system so autoreduction can be performed before any instrument scientist has needed to modify the script.

For Tester:

  1. SSH onto datareducedev.isis.cclrc.ac.uk
  2. cd /var/www/autoreduce_webapp
  3. python /var/www/autoreduce_webapp/manage.py test autoreduce_webapp.tests.QueueProcessorTestCase
  4. Verify all tests pass

Change History

comment:1 Changed 6 years ago by MarcusNoble

  • Status changed from new to assigned

comment:2 Changed 6 years ago by MarcusNoble

  • Status changed from assigned to inprogress

comment:3 Changed 6 years ago by MarcusNoble

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Description modified (diff)

comment:4 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:5 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Hi,

I received the following output:

[ajm64@datareducedev autoreduce_webapp]$ sudo su
[root@datareducedev autoreduce_webapp]# export PATH="/usr/local/bin:$PATH"
[root@datareducedev autoreduce_webapp]# python /var/www/autoreduce_webapp/manage.py test autoreduce_webapp.tests.QueueProcessorTestCase
Creating test database for alias 'default'...
FFFF..FF....F..FF...FF.F
======================================================================
FAIL: test_data_ready_existing_instrument (autoreduce_webapp.tests.QueueProcessorTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/for57625/autoreduce/WebApp/ISIS/autoreduce_webapp/autoreduce_webapp/tests.py", line 203, in test_data_ready_existing_instrument
    self.assertEqual(len(runs), 1, "Should only return 1 reduction run but returned %s" % len(runs))
AssertionError: Should only return 1 reduction run but returned 0

======================================================================
FAIL: test_data_ready_inactive_instrument (autoreduce_webapp.tests.QueueProcessorTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/for57625/autoreduce/WebApp/ISIS/autoreduce_webapp/autoreduce_webapp/tests.py", line 230, in test_data_ready_inactive_instrument
    self.assertEqual(len(runs), 1, "Should only return 1 reduction run but returned %s" % len(runs))
AssertionError: Should only return 1 reduction run but returned 0

======================================================================
FAIL: test_data_ready_multiple_runs (autoreduce_webapp.tests.QueueProcessorTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/for57625/autoreduce/WebApp/ISIS/autoreduce_webapp/autoreduce_webapp/tests.py", line 266, in test_data_ready_multiple_runs
    self.assertEqual(len(runs), 2, "Should only return 2 reduction runs but returned %s" % len(runs))
AssertionError: Should only return 2 reduction runs but returned 1

======================================================================
FAIL: test_data_ready_new_instrument (autoreduce_webapp.tests.QueueProcessorTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/for57625/autoreduce/WebApp/ISIS/autoreduce_webapp/autoreduce_webapp/tests.py", line 134, in test_data_ready_new_instrument
    self.assertEqual(len(runs), 1, "Should only return 1 reduction run but returned %s" % len(runs))
AssertionError: Should only return 1 reduction run but returned 0

======================================================================
FAIL: test_graphs_correctly_read_case_sensitive (autoreduce_webapp.tests.QueueProcessorTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/for57625/autoreduce/WebApp/ISIS/autoreduce_webapp/autoreduce_webapp/tests.py", line 784, in test_graphs_correctly_read_case_sensitive
    self.assertEqual(str(runs[0].status), "Completed", "Expecting status to be 'Completed' but was '%s'" % runs[0].status)
AssertionError: Expecting status to be 'Completed' but was 'Processing'

======================================================================
FAIL: test_graphs_correctly_read_multiple (autoreduce_webapp.tests.QueueProcessorTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/for57625/autoreduce/WebApp/ISIS/autoreduce_webapp/autoreduce_webapp/tests.py", line 740, in test_graphs_correctly_read_multiple
    self.assertEqual(str(runs[0].status), "Completed", "Expecting status to be 'Completed' but was '%s'" % runs[0].status)
AssertionError: Expecting status to be 'Completed' but was 'Processing'

======================================================================
FAIL: test_reduction_complete_reduction_run_exists (autoreduce_webapp.tests.QueueProcessorTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/for57625/autoreduce/WebApp/ISIS/autoreduce_webapp/autoreduce_webapp/tests.py", line 477, in test_reduction_complete_reduction_run_exists
    self.assertEqual(str(runs[0].status), "Completed", "Expecting status to be 'Completed' but was '%s'" % runs[0].status)
AssertionError: Expecting status to be 'Completed' but was 'Processing'

======================================================================
FAIL: test_reduction_error_reduction_run_exists (autoreduce_webapp.tests.QueueProcessorTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/for57625/autoreduce/WebApp/ISIS/autoreduce_webapp/autoreduce_webapp/tests.py", line 613, in test_reduction_error_reduction_run_exists
    self.assertEqual(str(runs[0].status), "Error", "Expecting status to be 'Error' but was '%s'" % runs[0].status)
AssertionError: Expecting status to be 'Error' but was 'Queued'

======================================================================
FAIL: test_reduction_error_reduction_run_exists_no_message (autoreduce_webapp.tests.QueueProcessorTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/for57625/autoreduce/WebApp/ISIS/autoreduce_webapp/autoreduce_webapp/tests.py", line 638, in test_reduction_error_reduction_run_exists_no_message
    self.assertEqual(str(runs[0].status), "Error", "Expecting status to be 'Error' but was '%s'" % runs[0].status)
AssertionError: Expecting status to be 'Error' but was 'Queued'

======================================================================
FAIL: test_reduction_started_reduction_run_error (autoreduce_webapp.tests.QueueProcessorTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/for57625/autoreduce/WebApp/ISIS/autoreduce_webapp/autoreduce_webapp/tests.py", line 448, in test_reduction_started_reduction_run_error
    self.assertEqual(str(runs[0].status), "Processing", "Expecting status to be 'Processing' but was '%s'" % runs[0].status)
AssertionError: Expecting status to be 'Processing' but was 'Error'

======================================================================
FAIL: test_reduction_started_reduction_run_exists (autoreduce_webapp.tests.QueueProcessorTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/for57625/autoreduce/WebApp/ISIS/autoreduce_webapp/autoreduce_webapp/tests.py", line 340, in test_reduction_started_reduction_run_exists
    self.assertEqual(str(runs[0].status), "Processing", "Expecting status to be 'Processing' but was '%s'" % runs[0].status)
AssertionError: Expecting status to be 'Processing' but was 'Queued'

======================================================================
FAIL: test_temporary_reduction_script_is_created (autoreduce_webapp.tests.QueueProcessorTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/for57625/autoreduce/WebApp/ISIS/autoreduce_webapp/autoreduce_webapp/tests.py", line 820, in test_temporary_reduction_script_is_created
    self.fail("Could not find temporary reduction script.")
AssertionError: Could not find temporary reduction script.

----------------------------------------------------------------------
Ran 24 tests in 27.614s

FAILED (failures=12)
Destroying test database for alias 'default'...

comment:6 Changed 6 years ago by Nick Draper

Moved to the backlog at the code freeze of R3.3

comment:7 Changed 6 years ago by Nick Draper

  • Milestone changed from Release 3.3 to Backlog

comment:8 Changed 6 years ago by Lottie Greenwood

  • Owner changed from MarcusNoble to Lottie Greenwood
Note: See TracTickets for help on using tickets.