Ticket #10507 (closed: fixed)
Cleanup clang warnings
| Reported by: | Steven Hahn | Owned by: | Steven Hahn |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.3 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Pete Peterson |
Description
Start eliminating as many warnings as I can from AppleClang on OSX.
Change History
comment:2 Changed 6 years ago by Steven Hahn
- Status changed from assigned to inprogress
Refs #10507. Cleanup clang warning in Mantid Algorithms.
Changeset: ac06f79d61ad336ad2c1588b0f3cc4f3efb4ffd7
comment:3 Changed 6 years ago by Steven Hahn
Refs #10507. fixing more clang warnings
Changeset: e82f714aff0f444eac278dd0f8b16db3832936cf
comment:4 Changed 6 years ago by Steven Hahn
Refs #10507. fix indent
Changeset: dc849f1008816d5d5a92e75a01cd1b714b3c7055
comment:5 Changed 6 years ago by Steven Hahn
Refs #10507. changed single line for loops so clang won't warn
Changeset: 69623d8ee2d6cb6a9552ac58f9c1bf1e7f54675b
comment:6 Changed 6 years ago by Steven Hahn
Refs #10507. cleanup formatting
Changeset: 5eff53d934ba779dd5cde04705abaf224f1cc3c6
comment:7 Changed 6 years ago by Steven Hahn
Refs #10507. Merge branch into develop
Conflicts:
Code/Mantid/MantidQt/SpectrumViewer/src/EModeHandler.cpp
Changeset: a31b4ebda2d607c73d9191809697c822c5ac5a99
comment:8 Changed 6 years ago by Steven Hahn
Refs #10507. fix doxygen warning
Changeset: 82ddece71dc5663ec171d79cbd759ab11422250d
comment:9 Changed 6 years ago by Steven Hahn
- Status changed from inprogress to verify
- Resolution set to fixed
This is being verified as pull request #63.
comment:10 Changed 6 years ago by Steven Hahn
retest this please
comment:11 Changed 6 years ago by Steven Hahn
Refs #10507. all warnings have been fixed or suppressed
Changeset: 03ecab470abb7f6b4730554a8bb4a18a91cd9b94
comment:12 Changed 6 years ago by Steven Hahn
targets "all" and "AllTests" should now build cleanly.
comment:13 Changed 6 years ago by Steven Hahn
Refs #10507. fix warnings on build servers
Changeset: d653e11670a551b69cc18184519c4f1cd486bb41
comment:14 Changed 6 years ago by Steven Hahn
Refs #10507. Fix merge conflict with master
Changeset: e7c709186e7644518bf39965a64c5d0512ade755
comment:15 Changed 6 years ago by Steven Hahn
Refs #10507. cleaner way to isolate clang
Changeset: 35b93996c91348de2bfdae9ced84e56245615119
comment:16 Changed 6 years ago by Steven Hahn
Revert "Refs #10507. cleaner way to isolate clang"
This reverts commit 35b93996c91348de2bfdae9ced84e56245615119.
Changeset: 2c5eaf4c562058be0feb023b7578bd0f2f68a9c3
comment:17 Changed 6 years ago by Steven Hahn
To fix a merging issue, I created a new branch and am cherry-picking commits to this branch. Therefore I'm closing this pull request without merging and creating a new pull request from the feature/10507_fix_clang_warnings_alt branch.
comment:18 Changed 6 years ago by Steven Hahn
Refs #10507. Cleanup clang warning in Mantid Algorithms.
Changeset: 3972c44e7bc2ed74acbdeb487eeb59bb3c6b3e56
comment:19 Changed 6 years ago by Steven Hahn
Refs #10507. fixing more clang warnings
Conflicts:
Code/Mantid/MantidQt/SpectrumViewer/src/EModeHandler.cpp
Changeset: 90b95afe10180268ae28fa0919e6edc5ce20cddf
comment:20 Changed 6 years ago by Steven Hahn
Refs #10507. fix indent
Conflicts:
Code/Mantid/MantidQt/SpectrumViewer/src/EModeHandler.cpp
Changeset: 421f46a46e7ae65551387f473016991e372503c8
comment:21 Changed 6 years ago by Steven Hahn
Refs #10507. changed single line for loops so clang won't warn
Changeset: 777334308b1c17242aa345504e7a7b8734f00426
comment:22 Changed 6 years ago by Steven Hahn
Refs #10507. cleanup formatting
Changeset: ab0b02863c8c5af52358be1b942c0fe6720a084b
comment:23 Changed 6 years ago by Steven Hahn
Refs #10507. fix doxygen warning
Changeset: 0a1ef20e58ec86d07a62fde2c2acaea682ffb28e
comment:24 Changed 6 years ago by Steven Hahn
Refs #10507. all warnings have been fixed or suppressed
Changeset: a5bf87a270b918cc9fd00366fa8d0ff6be77695a
comment:25 Changed 6 years ago by Steven Hahn
Refs #10507. alt branch now builds with zero warnings
Changeset: 780486490fd67504d05d89eaa27c6e8e5ea006c7
comment:26 Changed 6 years ago by Steven Hahn
This is being verified as pull request #65.
comment:27 Changed 6 years ago by Steven Hahn
Refs #10507. Merge 'feature/10507_fix_clang_warnings_alt' into develop
Conflicts:
Code/Mantid/Framework/API/test/WorkspaceFactoryTest.h Code/Mantid/Framework/Geometry/test/GroupTest.h Code/Mantid/Framework/ISISLiveData/inc/MantidISISLiveData/TCPEventStreamDefs.h Code/Mantid/Framework/LiveData/inc/MantidLiveData/ISIS/TCPEventStreamDefs.h
Changeset: c1ff229b35700d9d69e78a61d775a29af765585c
comment:28 Changed 6 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:29 Changed 6 years ago by Steven Hahn
The branch feature/10507_fix_clang_warnings has been deleted. Changes were merged into develop earlier this week.
comment:31 Changed 6 years ago by Pete Peterson
- Status changed from verifying to closed
Merge pull request #65 from mantidproject/feature/10507_fix_clang_warnings_alt
Feature/10507 fix clang warnings
Full changeset: 53b6221671064ec321ed4d0021e38b8af605c442
comment:32 Changed 6 years ago by Steven Hahn
Refs #10507. Cleanup clang warning in Mantid Algorithms.
Changeset: ac06f79d61ad336ad2c1588b0f3cc4f3efb4ffd7
comment:33 Changed 6 years ago by Steven Hahn
Refs #10507. fixing more clang warnings
Changeset: e82f714aff0f444eac278dd0f8b16db3832936cf
comment:34 Changed 6 years ago by Steven Hahn
Refs #10507. fix indent
Changeset: dc849f1008816d5d5a92e75a01cd1b714b3c7055
comment:35 Changed 6 years ago by Steven Hahn
Refs #10507. changed single line for loops so clang won't warn
Changeset: 69623d8ee2d6cb6a9552ac58f9c1bf1e7f54675b
comment:36 Changed 6 years ago by Steven Hahn
Refs #10507. cleanup formatting
Changeset: 5eff53d934ba779dd5cde04705abaf224f1cc3c6
comment:37 Changed 6 years ago by Steven Hahn
Refs #10507. Merge branch into develop
Conflicts:
Code/Mantid/MantidQt/SpectrumViewer/src/EModeHandler.cpp
Changeset: a31b4ebda2d607c73d9191809697c822c5ac5a99
comment:38 Changed 6 years ago by Steven Hahn
Refs #10507. fix doxygen warning
Changeset: 82ddece71dc5663ec171d79cbd759ab11422250d
comment:39 Changed 6 years ago by Steven Hahn
Refs #10507. all warnings have been fixed or suppressed
Changeset: 03ecab470abb7f6b4730554a8bb4a18a91cd9b94
comment:40 Changed 6 years ago by Steven Hahn
Refs #10507. fix warnings on build servers
Changeset: d653e11670a551b69cc18184519c4f1cd486bb41
comment:41 Changed 6 years ago by Steven Hahn
Refs #10507. Fix merge conflict with master
Changeset: e7c709186e7644518bf39965a64c5d0512ade755
comment:42 Changed 6 years ago by Steven Hahn
Refs #10507. cleaner way to isolate clang
Changeset: 35b93996c91348de2bfdae9ced84e56245615119
comment:43 Changed 6 years ago by Steven Hahn
Revert "Refs #10507. cleaner way to isolate clang"
This reverts commit 35b93996c91348de2bfdae9ced84e56245615119.
Changeset: 2c5eaf4c562058be0feb023b7578bd0f2f68a9c3
comment:44 Changed 6 years ago by Steven Hahn
Refs #10507. Merge 'feature/10507_fix_clang_warnings_alt' into develop
Conflicts:
Code/Mantid/Framework/API/test/WorkspaceFactoryTest.h Code/Mantid/Framework/Geometry/test/GroupTest.h Code/Mantid/Framework/ISISLiveData/inc/MantidISISLiveData/TCPEventStreamDefs.h Code/Mantid/Framework/LiveData/inc/MantidLiveData/ISIS/TCPEventStreamDefs.h
Changeset: c1ff229b35700d9d69e78a61d775a29af765585c
comment:45 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11349
