Ticket #1051 (closed: fixed)

Opened 11 years ago

Last modified 5 years ago

Binary Operation fails if dividing two workspaces coming out of FFT algorithm

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Iteration 21
Component: Keywords:
Cc: Blocked By:
Blocking: Tester:

Description


Attachments

Fourier.py​ (2.2 KB) - added by Russell Taylor 11 years ago.
Script from Spencer Howells
irs26173_ipg.nxs​ (496.8 KB) - added by Russell Taylor 11 years ago.
irs26176_ipg.nxs​ (496.6 KB) - added by Russell Taylor 11 years ago.

Change History

comment:1 Changed 11 years ago by Russell Taylor

  • Status changed from new to accepted

Changed 11 years ago by Russell Taylor

Script from Spencer Howells

Changed 11 years ago by Russell Taylor

Changed 11 years ago by Russell Taylor

comment:2 Changed 11 years ago by Russell Taylor

Attached script from Spencer fails in the Divide algorithm. The nxs data files are sample:irs26176 and resolution:irs26173.

comment:3 Changed 11 years ago by Russell Taylor

(In [3529]) Change test for unit compatibility to check unitID instead of testing for pointer equality, because the latter fails if dealing with a custom/non-UnitFactory unit. Re #1051.

comment:4 Changed 11 years ago by Russell Taylor

(In [3531]) So that's why we weren't just checking the unitID in the first place... Re #1051.

comment:5 Changed 11 years ago by Russell Taylor

(In [3532]) The same test on the unit pointer was going on in ConjoinWorkspaces. Re #1051.

comment:6 Changed 11 years ago by Russell Taylor

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:7 Changed 11 years ago by Russell Taylor

  • Status changed from testing to reopened
  • Resolution fixed deleted

comment:8 Changed 11 years ago by Russell Taylor

(In [3538]) Remove a constraint on spectraMap added to ConjoinWorkspaces yesterday. Re #1051.

comment:9 Changed 11 years ago by Russell Taylor

  • Status changed from reopened to accepted

comment:10 Changed 11 years ago by Russell Taylor

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:11 Changed 11 years ago by Martyn Gigg

  • Status changed from testing to closed

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1899

Note: See TracTickets for help on using tickets.