Clang Warnings

[Peter Parker]

Slack message from Steven Hahn:

Some of your code in Refs #5308 (https://github.com/mantidproject/mantid/commit/9c4606692a4d4f60cc3fb2cb9bc591fb23837bf3) is generating warning in osx with the clang compiler. Would you please rework the following lines?

/Users/svh/Documents/MantidProject/mantid/Code/Mantid/MantidQt/CustomInterfaces/src/CalcCorr.cpp:292:5: warning: ignoring return value of function declared with warn_unused_result attribute [-Wunused-result]
   runPythonCode(pyInput).trimmed();
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
[1005/1462] Building CXX object Mantid...s/CustomInterfaces.dir/src/Elwin.cpp.o
/Users/svh/Documents/MantidProject/mantid/Code/Mantid/MantidQt/CustomInterfaces/src/Elwin.cpp:122:5: warning: ignoring return value of function declared with warn_unused_result attribute [-Wunused-result]
   runPythonCode(pyInput).trimmed();
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.
[1010/1462] Building CXX object Mantid.../CustomInterfaces.dir/src/MSDFit.cpp.o
/Users/svh/Documents/MantidProject/mantid/Code/Mantid/MantidQt/CustomInterfaces/src/MSDFit.cpp:86:5: warning: ignoring return value of function declared with warn_unused_result attribute [-Wunused-result]
   runPythonCode(pyInput).trimmed();
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

[Peter Parker]

Refs #10527 - Fix Clang compiler warnings.

Changeset: 5dde572049ba4ab8c807d498636a8a5e540b3503

[Peter Parker]

After getting some merge conflicts during a checkbuild, it became apparent that these warnings have actually already been fixed as part of #10527 in the following commit:

​https://github.com/mantidproject/mantid/commit/cac2596d72c579c7cb29d26c7587604442662030

They'll see their way into master once that ticket has been tested.

Closing this ticket as invalid and deleting the branch.

[Dan Nixon]

I added a fix for this in #10368 (specifically 7cce79a844a4ddfa9a4810faa584808a9e6e1592).

[Stuart Campbell]

This ticket has been transferred to github issue ​11369