Ticket #10533 (closed: fixed)
Bugfix ThreeSlice View issue in Vates
| Reported by: | Anton Piccardo-Selg | Owned by: | Anton Piccardo-Selg |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.3 |
| Component: | GUI | Keywords: | Vates |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Martyn Gigg |
Description
When switching from StandardView to ThreeSliceView on a Windows (7) platform, Mantid crashes.
Change History
comment:2 Changed 6 years ago by Anton Piccardo-Selg
For Testing
- Please find the clean install for Win 7 at http://builds.mantidproject.org/job/develop_clean/476/label=win7-build/ and install it. When starting the program, set the ParaView path to a valid destination.
- Load an MD-Histo workspace into Mantid. Then open it in the Vates Simple Interface.
- The workspace will load in the standard view. Click the three-slice view button.
- The three-slice view should open and display the workspace data.
- Repeat steps 2-4 with an MD-Event workspace.
- Both procedures should not cause any issues anymore.
Code Review
These changes should be code reviewed.
Changes were made to the ConfigService, to ask for the path of ParaView. This is a simple getter method. The MdViewerWidget was modified to pass the path to ParaView to the pqPVApplicationCore method. The ThreeSliceView constructor was modified to pass the full path of the QuadView.dll to ParaView's loadExtension method.
comment:4 Changed 6 years ago by Owen Arnold
Can you please set this ticket status to Resolved as Fixed
comment:5 Changed 6 years ago by Anton Piccardo-Selg
- Status changed from assigned to verify
- Resolution set to fixed
comment:6 Changed 6 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:7 Changed 6 years ago by Martyn Gigg
- Status changed from verifying to reopened
- Resolution fixed deleted
The three slice view seems to work fine in Windows now.
While the code changes themselves look okay it would seem from https://github.com/mantidproject/mantid/compare/bugfix/10533_threeSlice_issue_vates that the tab/space settings on your IDE are not quite right. Could we fix this now?
comment:8 Changed 6 years ago by Anton Piccardo-Selg
- Status changed from reopened to inprogress
Refs #10533 Replace tabs with spaces
Changeset: a2f7d8d713727a74b7b571c1c7baf47d378d02d6
comment:9 Changed 6 years ago by Anton Piccardo-Selg
- Status changed from inprogress to verify
- Resolution set to fixed
comment:11 Changed 6 years ago by Martyn Gigg
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/10533_threeSlice_issue_vates'
Full changeset: c8462bd0bc6f3761314e755be268aba5dd0745d0
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 11375
Provide absolute path for PV to find QuadView.dll Refs #10533
When switching from standard view to three slice view in Vates on a Windows 7 machine, the application crashes. ParaView is not able to find the required DLLs. Providing the absolute path to the DLLs to ParaView solves the issue.
Changeset: af7418b798bd01b685e94b1102f4ea7a210c72a0