Ticket #10535 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

IntegratePeaksMD does not zero intensity for peaks on edge

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Andrei Savici

Description

When reintegrating a peaks workspace with IntegrateIfOnEdge false, the intensity is not changed to zero for peaks on the edge.

Change History

comment:1 Changed 6 years ago by Vickie Lynch

Refs #10535 zero edge intensity

Changeset: 2671ccba22e916f44f63b84a8cc23b5c1977c6a3

comment:2 Changed 6 years ago by Vickie Lynch

Revert "Refs #10535 zero edge intensity"

This reverts commit 2671ccba22e916f44f63b84a8cc23b5c1977c6a3.

Changeset: 762b2934d3b82e3c5608789aad042a30396d1078

comment:3 Changed 6 years ago by Vickie Lynch

Refs #10535 zero edge intensity

Changeset: 044b776ddfae148947b8c33f54bb4a1cc0d88686

comment:4 Changed 6 years ago by Vickie Lynch

  • Status changed from new to assigned

Test with file from systemtest/Data. Open peaks workspace after first call to IntegratePeaksMD and see that all peaks are integrated. Open again after second call and see that edge peaks have 0 in the Intens and SigInt columns.

Load(Filename='TOPAZ_3132_event.nxs', OutputWorkspace='TOPAZ_3132_event', LoaderName='LoadEventNexus', LoaderVersion=1, LoadMonitors=True)
ConvertToMD(InputWorkspace='TOPAZ_3132_event', QDimensions='Q3D', dEAnalysisMode='Elastic', Q3DFrames='Q_sample', LorentzCorrection=True, OutputWorkspace='TOPAZ_3132_md', MinValues='-25,-25,-25', MaxValues='25,25,25', SplitInto='2', SplitThreshold=50, MaxRecursionDepth=13, MinRecursionDepth=7)
FindPeaksMD(InputWorkspace='TOPAZ_3132_md', PeakDistanceThreshold=0.37680000000000002, MaxPeaks=50, DensityThresholdFactor=100, OutputWorkspace='TOPAZ_3132_peaks')
FindUBUsingFFT(PeaksWorkspace='TOPAZ_3132_peaks', MinD=3, MaxD=15, Tolerance=0.12)
CopySample(InputWorkspace='TOPAZ_3132_peaks', OutputWorkspace='TOPAZ_3132_md', CopyName=False, CopyMaterial=False, CopyEnvironment=False, CopyShape=False)
CopySample(InputWorkspace='TOPAZ_3132_peaks', OutputWorkspace='TOPAZ_3132_event', CopyName=False, CopyMaterial=False, CopyEnvironment=False, CopyShape=False)
IndexPeaks(PeaksWorkspace='TOPAZ_3132_peaks', Tolerance=0.12, NumIndexed=50, AverageError=0.011554102677988988)
ShowPossibleCells(PeaksWorkspace='TOPAZ_3132_peaks', NumberOfCells=3, AllowPermutations=False)
ConvertToMD(InputWorkspace='TOPAZ_3132_event', QDimensions='Q3D', dEAnalysisMode='Elastic', Q3DFrames='Q_sample', OutputWorkspace='__MantidEVWorker_sphere_integrate_temp_MD_ws', MinValues='-30,-30,-30', MaxValues='30,30,30', SplitInto='2,2,2', SplitThreshold=200, MaxRecursionDepth=10, MinRecursionDepth=7)
IntegratePeaksMD(InputWorkspace='__MantidEVWorker_sphere_integrate_temp_MD_ws', PeakRadius=0.17999999999999999, BackgroundInnerRadius=0.17999999999999999, BackgroundOuterRadius=0.23000000000000001, PeaksWorkspace='TOPAZ_3132_peaks', OutputWorkspace='TOPAZ_3132_peaks', CylinderLength=0.40000000000000002, PercentBackground=20)
IntegratePeaksMD(InputWorkspace='TOPAZ_3132_md', PeakRadius=0.17999999999999999, BackgroundInnerRadius=0.17999999999999999, BackgroundOuterRadius=0.23000000000000001, PeaksWorkspace='TOPAZ_3132_peaks', OutputWorkspace='TOPAZ_3132_peaks', IntegrateIfOnEdge=False, CylinderLength=0.25, PercentBackground=20)

comment:5 Changed 6 years ago by Vickie Lynch

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:6 Changed 6 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:7 Changed 6 years ago by Vickie Lynch

Refs #10535 coding change suggested by Andrei

Changeset: 79c0ad72f61a4231f5b1bd8d66aedcbe9f9a42ca

comment:8 Changed 6 years ago by Vickie Lynch

Refs #10535 remove outer loop

Changeset: 34b872205c8eeed92405fc20560e14691b02af67

comment:9 Changed 6 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10535_zero_edge_intensity'

Full changeset: 21ec18e68de490fc44b83b505e7514bff70fa56f

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11377

Note: See TracTickets for help on using tickets.