Ticket #10541 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Intensity and Sigma wrong for NoFIt IntegratePeaksMD2

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description

The INTI and SIGI values that are given for each peak in the profile file are not correct. The INTI that is given is the sum of all 100 counts and the SIGI is the square root. It should be

INTI = Peak - Ratio*Bkgd SIGI = sqrt(Peak + Ratio*Ratio*Bkgd)

If the Peak is the sum of the middle 80 channels, then BKGD is the sum of channels 0-9 plus 90-99. The Ratio is then 80/20 = 4.

Attachments

verify10541.py​ (594 bytes) - added by Vickie Lynch 6 years ago.
testing script
verify10541.peaks​ (781 bytes) - added by Vickie Lynch 6 years ago.
peaks file for testing
verify10541.mat​ (564 bytes) - added by Vickie Lynch 6 years ago.
UB matrix for testing
NoFit_integration.ods​ (11.3 KB) - added by Vickie Lynch 6 years ago.
Correct peak results from Art Shultz

Change History

comment:1 Changed 6 years ago by Vickie Lynch

Refs #10541 sum background for NoFit and add MANDI to MaskBTP

Changeset: 4caeae0ce8546b8e24d3ee4c4c59fe0ca7c8168e

comment:2 Changed 6 years ago by Vickie Lynch

Refs #10541 fix intensity sum and zero at profile edge

Changeset: 25018a3e9588db3e5d0e5b1909e66b161b2a23f5

Changed 6 years ago by Vickie Lynch

testing script

Changed 6 years ago by Vickie Lynch

peaks file for testing

Changed 6 years ago by Vickie Lynch

UB matrix for testing

Changed 6 years ago by Vickie Lynch

Correct peak results from Art Shultz

comment:3 Changed 6 years ago by Vickie Lynch

  • Status changed from new to assigned

To test run attached script and check that Intens and SigInt match those in attached spreadsheet.

comment:4 Changed 6 years ago by Vickie Lynch

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:6 Changed 6 years ago by Wenduo Zhou

  • Status changed from verifying to verify
  • Tester Wenduo Zhou deleted

comment:7 Changed 6 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:8 Changed 6 years ago by Wenduo Zhou

The algorithm works as it is required. It is closed.

ConvertToDiffractionMDWorkspace is slow, though it is parallelized. From the monitor, I could see that all the threads did not work in full power (only 10 to 30 percent). There might be some space to improve the performance of the algorithm.

Last edited 6 years ago by Wenduo Zhou (previous) (diff)

comment:9 Changed 6 years ago by Wenduo Zhou

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10541_nofit_cylindrical_intensity'

Full changeset: ​70d620a30a93813514d0b64bc8300ab7877a8f99

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​11383

Note: See TracTickets for help on using tickets.