Ticket #10550 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Allow the suppression of alg start and end logs

Reported by: Nick Draper Owned by: Nick Draper
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #8924 Tester: Dan Nixon

Description

And make use of this in Framework manager for DownloadInstrument

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from assigned to inprogress

re #10550 initial code changes

Changeset: 0c6daebdc47e61076106f54019a929f1ef0fb0c7

comment:3 Changed 6 years ago by Nick Draper

re #10550 improvements and python enabling

Changeset: 48ad9e40deed8db4315526b182970cc7166f7850

comment:4 Changed 6 years ago by Nick Draper

  • Blocking 8924 added
  • Blocked By 8924 removed

comment:5 Changed 6 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test:

  1. Check that the unit tests pass
  2. Run the following python script, No messages should come onto the log at Notice level, (you can still see the parameters if you lower your log level if you wnat to check that logging was still working).
    palg = AlgorithmManager.create("Pause")
    print palg.getAlgStartupLogging()
    palg.setAlgStartupLogging(False)
    print palg.getAlgStartupLogging()
    palg.execute()
    

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

comment:7 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to reopened
  • Resolution fixed deleted

When running with the option disabled I still get an entry in the log, all be it an empty one, but it does add blocks of white space to the Results Log.

Pause-[Notice] 

comment:8 Changed 6 years ago by Nick Draper

  • Status changed from reopened to inprogress

re #10550 improved the catching of log messages

Changeset: 66c1e11b13da56ebb780d258e71feb045d40edcb

comment:9 Changed 6 years ago by Nick Draper

  • Status changed from inprogress to verify
  • Resolution set to fixed

Updated to test

  1. Check that the unit tests pass
  2. Run the following python script, No messages should come onto the log at Notice level.
    #This should log nothing
    palg = AlgorithmManager.create("Pause")
    print palg.getAlgStartupLogging()
    palg.setAlgStartupLogging(False)
    print palg.getAlgStartupLogging()
    palg.execute()
    
    #this should log only the messages from inside the alg itself or errors
    #the highest level message is Information in this example
    palg = AlgorithmManager.create("LoadRaw")
    palg.setProperty("Filename","CSP78173")
    palg.setProperty("OutputWorkspace","output")
    print palg.getAlgStartupLogging()
    palg.setAlgStartupLogging(False)
    print palg.getAlgStartupLogging()
    palg.execute()
    
    

comment:10 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying

comment:11 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/10550_alg_startup_logging'

Full changeset: f62604a1deb007df15e6036c74b6acef612de539

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 11392

Note: See TracTickets for help on using tickets.